Fix misleading ParseConfig error when default_query_exec_mode is invalid

skarm · skarm · commit 03c69e4a2599 · 2026-01-10T15:17:03.000+05:00
diff --git a/conn.go b/conn.go
@@ -203,7 +203,9 @@ func ParseConfigWithOptions(connString string, options ParseConfigOptions) (*Con
 		case "simple_protocol":
 			defaultQueryExecMode = QueryExecModeSimpleProtocol
 		default:
-			return nil, pgconn.NewParseConfigError(connString, "invalid default_query_exec_mode", err)
+			return nil, pgconn.NewParseConfigError(
+				connString, "invalid default_query_exec_mode", fmt.Errorf("unknown value %q", s),
+			)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,9 @@ func ParseConfigWithOptions(connString string, options ParseConfigOptions) (*Con`
`203`	`203`	`case "simple_protocol":`
`204`	`204`	`defaultQueryExecMode = QueryExecModeSimpleProtocol`
`205`	`205`	`default:`
`206`		`- return nil, pgconn.NewParseConfigError(connString, "invalid default_query_exec_mode", err)`
	`206`	`+ return nil, pgconn.NewParseConfigError(`
	`207`	`+ connString, "invalid default_query_exec_mode", fmt.Errorf("unknown value %q", s),`
	`208`	`+ )`
`207`	`209`	`}`
`208`	`210`	`}`
`209`	`211`