Merge pull request #2555 from jaltavilla/load-types-errcheck

jackc · web-flow · commit 3638a2bc3017 · 2026-05-13T16:42:28.000-05:00
Add missing error check of rows.Err to load types.
diff --git a/derived_types.go b/derived_types.go
@@ -236,6 +236,11 @@ func (c *Conn) LoadTypes(ctx context.Context, typeNames []string) ([]*pgtype.Typ
 		}
 		result = append(result, type_)
 	}
+
+	if err := rows.Err(); err != nil {
+		return nil, fmt.Errorf("While processing rows: %w", err)
+	}
+
 	return result, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -236,6 +236,11 @@ func (c Conn) LoadTypes(ctx context.Context, typeNames []string) ([]pgtype.Typ`
`236`	`236`	`}`
`237`	`237`	`result = append(result, type_)`
`238`	`238`	`}`
	`239`	`+`
	`240`	`+ if err := rows.Err(); err != nil {`
	`241`	`+ return nil, fmt.Errorf("While processing rows: %w", err)`
	`242`	`+ }`
	`243`	`+`
`239`	`244`	`return result, nil`
`240`	`245`	`}`
`241`	`246`