Skip to content

fix(pgxpool): pass base context to BeforeConnect from background healthcheck #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blackwell-systems wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(pgxpool): pass base context to BeforeConnect from background healthcheck #2546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fd6ab5
fix(pgxpool): pass base context to BeforeConnect from background heal…
blackwell-systems Apr 30, 2026
9262a9a
fix: use context.WithoutCancel to prevent stale cancellation on pool …
blackwell-systems May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pgxpool/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ type Pool struct {
healthCheckTimer *time.Timer

healthCheckChan chan struct{}
baseCtx context.Context

acquireTracer AcquireTracer
releaseTracer ReleaseTracer
Expand Down Expand Up @@ -250,6 +251,7 @@ func NewWithConfig(ctx context.Context, config *Config) (*Pool, error) {
healthCheckPeriod: config.HealthCheckPeriod,
healthCheckChan: make(chan struct{}, 1),
closeChan: make(chan struct{}),
baseCtx: context.WithoutCancel(ctx),
}

if t, ok := config.ConnConfig.Tracer.(AcquireTracer); ok {
Expand Down Expand Up @@ -561,7 +563,7 @@ func (p *Pool) checkMinConns() error {
stat := p.Stat()
toCreate := max(p.minConns-stat.TotalConns(), p.minIdleConns-stat.IdleConns())
if toCreate > 0 {
return p.createIdleResources(context.Background(), int(toCreate))
return p.createIdleResources(p.baseCtx, int(toCreate))
}
return nil
}
Expand Down
Loading