Merge pull request #516 from jacksec-engineer/finding-autofix-37eeb6f0

fix(code-quality): Fix for Explicit returns mixed with implicit (fall through) returns

Author: jackseceng

app/app.py

@@ -115,6 +115,7 @@ def input_url():
                         elif message is not None:
                             # 500 error returned for database failure
                             abort(HTTPStatus.INTERNAL_SERVER_ERROR)
+                            return None
 
                 # Return link page with URL if successful
                 resp = make_response(
@@ -187,8 +188,7 @@ def redirect_url(arg):
             hashsum = hashlib.sha256(requested_path.encode("utf-8")).hexdigest()
             url_bytes, salt_bytes = db.get_link(hashsum)
             if url_bytes is False:
-                abort(HTTPStatus.NOT_FOUND)
-                return None
+                return page_not_found(HTTPStatus.NOT_FOUND)
             else:
                 db.increment_click(hashsum)
                 newlink = urls.decrypt_url(
@@ -199,6 +199,8 @@ def redirect_url(arg):
                 )
                 return resp
 
+    return internal_server_error(HTTPStatus.INTERNAL_SERVER_ERROR)
+
 
 @application.after_request
 def add_security_headers(resp):