fix(adapters): drop silent-sentinel row fallbacks across Apple Podcasts, Reddit, and Gitee (#1634)

* fix(adapters): drop silent-sentinel row fallbacks across Apple Podcasts, Reddit, and Gitee

Continues the audit-baseline cleanup from #1611 (lesswrong) and #1631
(wikipedia / 36kr / xiaoyuzhou / zhihu), and follows the direction set
by 7164615 (silent-empty-fallback resolutions across Douyin / Jike /
WeRead) and ee54eb8 (ignore sentinels in thrown errors).

Replaces silent-sentinel row fallbacks with the empty-string signal so
agents can tell apart "field has value Unknown" from "upstream returned
no value":

- apple-podcasts/search: episodes, genre
- reddit/saved: title
- reddit/upvoted: title
- gitee/search: language, description

All four files audited for downstream sentinel checks via
`grep -nE "=== ?['\"](Unknown|unknown|-)['\"]"`. None reference the
swapped values in control flow (verified against the v2ex/me.js class
of regression caught in #1631).

Intentionally skipped in this batch (will not flip to empty):
- gitee/trending.js:272: downstream `project.description !== '-'`
  check drives the mergedDescription fallback. Same control-flow
  sentinel pattern as v2ex/me.js. Stays on baseline.
- web/read.js x4: `'-'` lives inside rendered diagnostic lines
  (`lines.push(...)`), not row fields. Empty would render
  `  GET    /a/b` with a doubled space. UX placeholder.
- yollomi/{edit,video}.js x6: `file: '-'`, `size: '-'`, `credits: '-'`
  are user-facing status rows displayed to humans. Empty would
  collapse columns visually.
- zsxq/dynamics.js: `title: '[${d.action || 'unknown'}]'` is a
  template-literal-rendered title prefix. Empty would render `[]`.

Verified live: `opencli apple-podcasts search "lex fridman" --limit 2`
returns populated episodes/genre. `opencli gitee search "vue" --limit 2`
returns populated language/description. Baseline shrinks accordingly.

* test(adapters): add empty-signal coverage for the cluster-3 sentinel swap

Mirrors the cluster-2 test additions, pairing the sentinel value swap
in this PR with focused unit tests that mock the upstream to return
null / missing fields and assert the row surfaces an empty-string
signal instead of the old fabricated '-' / 'unknown' sentinel.

Coverage:

- clis/apple-podcasts/commands.test.js (+1 case): stubs the iTunes
  Search response with a result that has collectionId / collectionName
  / artistName populated but no trackCount and no primaryGenreName.
  Asserts episodes and genre render as '' (was '-' before this PR).

- clis/gitee/search.test.js (new): mocks Gitee's `so.gitee.com/v1/search`
  fetch with two cases - a hit that has only title + url (no langs,
  no description), and a hit that has all fields populated. Asserts
  the missing fields render as '' (was '-' before) and that populated
  fields pass through verbatim.

The reddit/saved and reddit/upvoted changes in this PR live inside a
page.evaluate template literal that fetches from reddit.com inside
the browser context, so the empty-signal branch is executed inside
the page rather than in adapter JS. They are 1-char `|| '-'` ->
`|| ''` swaps with no downstream sentinel consumer and the same JS
semantics demonstrated by the gitee + apple-podcasts tests above.

* chore: rebuild cli-manifest.json to drop stale entries from rebase

The previous rebase left a stale linkedin/people-search entry in
cli-manifest.json that was carried over from a sibling feature branch.
This branch does not include the people-search source file, so the
entry was an orphan; CI's build-manifest safety check correctly
refused to overwrite it. Regenerating with --allow-removals to drop
the orphaned entry, after which a normal `npm run build` is a no-op.

Author: Benjamin-eecs

clis/apple-podcasts/commands.test.js

@@ -41,6 +41,26 @@ describe('apple-podcasts search command', () => {
             }),
         ]);
     });
+    it('emits empty-string for missing trackCount and primaryGenreName instead of a sentinel', async () => {
+        const cmd = getRegistry().get('apple-podcasts/search');
+        const fetchMock = vi.fn().mockResolvedValue({
+            ok: true,
+            json: () => Promise.resolve({
+                results: [
+                    {
+                        collectionId: 99,
+                        collectionName: 'No-Meta Show',
+                        artistName: 'Anon Host',
+                        collectionViewUrl: 'https://example.com/p/99',
+                    },
+                ],
+            }),
+        });
+        vi.stubGlobal('fetch', fetchMock);
+        const result = await cmd.func({ query: 'no-meta', limit: 1 });
+        expect(result[0].episodes).toBe('');
+        expect(result[0].genre).toBe('');
+    });
 });
 describe('apple-podcasts top command', () => {
     beforeEach(() => {

clis/apple-podcasts/search.js

@@ -23,8 +23,8 @@ cli({
             id: p.collectionId,
             title: p.collectionName,
             author: p.artistName,
-            episodes: p.trackCount ?? '-',
-            genre: p.primaryGenreName ?? '-',
+            episodes: p.trackCount ?? '',
+            genre: p.primaryGenreName ?? '',
             url: p.collectionViewUrl || '',
         }));
     },

clis/gitee/search.js

@@ -123,8 +123,8 @@ cli({
             rows.push({
                 rank: rows.length + 1,
                 name,
-                language: normalizeText(getFirstText(fields.langs)) || '-',
-                description: normalizeText(getFirstText(fields.description)) || '-',
+                language: normalizeText(getFirstText(fields.langs)) || '',
+                description: normalizeText(getFirstText(fields.description)) || '',
                 stars: normalizeStars(fields['count.star']),
                 url: repoUrl,
             });

clis/gitee/search.test.js

@@ -0,0 +1,65 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { getRegistry } from '@jackwener/opencli/registry';
+import './search.js';
+
+function mockGiteeResponse(hits) {
+    return {
+        ok: true,
+        json: () => Promise.resolve({ hits: { hits } }),
+    };
+}
+
+function makePage() {
+    return {
+        goto: vi.fn().mockResolvedValue(undefined),
+        wait: vi.fn().mockResolvedValue(undefined),
+    };
+}
+
+describe('gitee search', () => {
+    beforeEach(() => {
+        vi.restoreAllMocks();
+    });
+    afterEach(() => {
+        vi.unstubAllGlobals();
+    });
+
+    it('emits empty-string for missing language / description instead of a sentinel', async () => {
+        const cmd = getRegistry().get('gitee/search');
+        expect(cmd?.func).toBeTypeOf('function');
+        const fetchMock = vi.fn().mockResolvedValue(mockGiteeResponse([
+            {
+                fields: {
+                    title: 'someuser/no-meta-repo',
+                    url: 'https://gitee.com/someuser/no-meta-repo',
+                },
+            },
+        ]));
+        vi.stubGlobal('fetch', fetchMock);
+        const rows = await cmd.func(makePage(), { keyword: 'test', limit: 10 });
+        expect(rows).toHaveLength(1);
+        expect(rows[0].name).toBe('someuser/no-meta-repo');
+        expect(rows[0].language).toBe('');
+        expect(rows[0].description).toBe('');
+    });
+
+    it('passes through populated language / description verbatim', async () => {
+        const cmd = getRegistry().get('gitee/search');
+        const fetchMock = vi.fn().mockResolvedValue(mockGiteeResponse([
+            {
+                fields: {
+                    title: 'org/repo-a',
+                    url: 'https://gitee.com/org/repo-a',
+                    langs: 'TypeScript',
+                    description: 'A test repo',
+                    'count.star': '42',
+                },
+            },
+        ]));
+        vi.stubGlobal('fetch', fetchMock);
+        const rows = await cmd.func(makePage(), { keyword: 'test', limit: 10 });
+        expect(rows[0].language).toBe('TypeScript');
+        expect(rows[0].description).toBe('A test repo');
+        expect(rows[0].stars).toBe('42');
+    });
+});

clis/reddit/saved.js

@@ -30,7 +30,7 @@ cli({
         });
         const d = await res.json();
         return (d?.data?.children || []).map(c => ({
-          title: c.data.title || c.data.body?.slice(0, 100) || '-',
+          title: c.data.title || c.data.body?.slice(0, 100) || '',
           subreddit: c.data.subreddit_name_prefixed || 'r/' + (c.data.subreddit || '?'),
           score: c.data.score || 0,
           comments: c.data.num_comments || 0,

clis/reddit/upvoted.js

@@ -30,7 +30,7 @@ cli({
         });
         const d = await res.json();
         return (d?.data?.children || []).map(c => ({
-          title: c.data.title || '-',
+          title: c.data.title || '',
           subreddit: c.data.subreddit_name_prefixed || 'r/' + (c.data.subreddit || '?'),
           score: c.data.score || 0,
           comments: c.data.num_comments || 0,

scripts/typed-error-lint-baseline.json

@@ -819,15 +819,15 @@
     "rule": "silent-clamp",
     "command": "zhihu/collection",
     "file": "clis/zhihu/collection.js",
-    "line": 141,
+    "line": 154,
     "text": "const currentFetchLimit = Math.min(pageLimit, requestedLimit - collected.length);",
     "occurrence": 0
   },
   {
     "rule": "silent-clamp",
     "command": "zhihu/collection",
     "file": "clis/zhihu/collection.js",
-    "line": 130,
+    "line": 143,
     "text": "const pageLimit = Math.min(requestedLimit, 20); // 知乎 API 限制每页最大 20",
     "occurrence": 0
   },
@@ -855,22 +855,6 @@
     "text": "const limit = Math.max(1, Math.min(Number(args.limit) || 10, 25));",
     "occurrence": 0
   },
-  {
-    "rule": "silent-sentinel",
-    "command": "apple-podcasts/search",
-    "file": "clis/apple-podcasts/search.js",
-    "line": 26,
-    "text": "episodes: p.trackCount ?? '-',",
-    "occurrence": 0
-  },
-  {
-    "rule": "silent-sentinel",
-    "command": "apple-podcasts/search",
-    "file": "clis/apple-podcasts/search.js",
-    "line": 27,
-    "text": "genre: p.primaryGenreName ?? '-',",
-    "occurrence": 0
-  },
   {
     "rule": "silent-sentinel",
     "command": "bilibili/download",
@@ -887,22 +871,6 @@
     "text": "const jobName = f.jobName || 'unknown';",
     "occurrence": 0
   },
-  {
-    "rule": "silent-sentinel",
-    "command": "gitee/search",
-    "file": "clis/gitee/search.js",
-    "line": 127,
-    "text": "description: normalizeText(getFirstText(fields.description)) || '-',",
-    "occurrence": 0
-  },
-  {
-    "rule": "silent-sentinel",
-    "command": "gitee/search",
-    "file": "clis/gitee/search.js",
-    "line": 126,
-    "text": "language: normalizeText(getFirstText(fields.langs)) || '-',",
-    "occurrence": 0
-  },
   {
     "rule": "silent-sentinel",
     "command": "gitee/trending",
@@ -935,22 +903,6 @@
     "text": "prompt: params.prompt || item.common_attr?.title || 'N/A',",
     "occurrence": 0
   },
-  {
-    "rule": "silent-sentinel",
-    "command": "reddit/saved",
-    "file": "clis/reddit/saved.js",
-    "line": 33,
-    "text": "title: c.data.title || c.data.body?.slice(0, 100) || '-',",
-    "occurrence": 0
-  },
-  {
-    "rule": "silent-sentinel",
-    "command": "reddit/upvoted",
-    "file": "clis/reddit/upvoted.js",
-    "line": 33,
-    "text": "title: c.data.title || '-',",
-    "occurrence": 0
-  },
   {
     "rule": "silent-sentinel",
     "command": "twitter/accept",