refactor(adapter): split browser command signatures (#1237)

Author: jackwener

clis/36kr/news.js

@@ -12,7 +12,7 @@ cli({
         { name: 'limit', type: 'int', default: 20, help: 'Number of articles (max 50)' },
     ],
     columns: ['rank', 'title', 'summary', 'date', 'url'],
-    func: async (_page, kwargs) => {
+    func: async (kwargs) => {
         const count = Math.min(kwargs.limit || 20, 50);
         const resp = await fetch('https://www.36kr.com/feed', {
             headers: { 'User-Agent': 'Mozilla/5.0 (compatible; opencli/1.0)' },

clis/apple-podcasts/commands.test.js

@@ -24,7 +24,7 @@ describe('apple-podcasts search command', () => {
             }),
         });
         vi.stubGlobal('fetch', fetchMock);
-        const result = await cmd.func(null, {
+        const result = await cmd.func({
             query: 'machine learning',
             keyword: 'sports',
             limit: 5,
@@ -60,7 +60,7 @@ describe('apple-podcasts top command', () => {
             }),
         });
         vi.stubGlobal('fetch', fetchMock);
-        await cmd.func(null, { country: 'US', limit: 1 });
+        await cmd.func({ country: 'US', limit: 1 });
         const [, options] = fetchMock.mock.calls[0] ?? [];
         expect(options).toBeDefined();
         expect(options.signal).toBeDefined();
@@ -81,7 +81,7 @@ describe('apple-podcasts top command', () => {
             }),
         });
         vi.stubGlobal('fetch', fetchMock);
-        const result = await cmd.func(null, { country: 'US', limit: 2 });
+        const result = await cmd.func({ country: 'US', limit: 2 });
         expect(fetchMock).toHaveBeenCalledWith('https://rss.marketingtools.apple.com/api/v2/us/podcasts/top/2/podcasts.json', expect.objectContaining({
             signal: expect.any(Object),
         }));
@@ -94,6 +94,6 @@ describe('apple-podcasts top command', () => {
         const cmd = getRegistry().get('apple-podcasts/top');
         expect(cmd?.func).toBeTypeOf('function');
         vi.stubGlobal('fetch', vi.fn().mockRejectedValue(new Error('socket hang up')));
-        await expect(cmd.func(null, { country: 'us', limit: 3 })).rejects.toThrow('Unable to reach Apple Podcasts charts for US');
+        await expect(cmd.func({ country: 'us', limit: 3 })).rejects.toThrow('Unable to reach Apple Podcasts charts for US');
     });
 });

clis/apple-podcasts/episodes.js

@@ -12,7 +12,7 @@ cli({
         { name: 'limit', type: 'int', default: 15, help: 'Max episodes to show' },
     ],
     columns: ['title', 'duration', 'date'],
-    func: async (_page, args) => {
+    func: async (args) => {
         const limit = Math.max(1, Math.min(Number(args.limit), 200));
         // results[0] is the podcast itself; the rest are episodes
         const data = await itunesFetch(`/lookup?id=${args.id}&entity=podcastEpisode&limit=${limit + 1}`);

clis/apple-podcasts/search.js

@@ -12,7 +12,7 @@ cli({
         { name: 'limit', type: 'int', default: 10, help: 'Max results' },
     ],
     columns: ['id', 'title', 'author', 'episodes', 'genre', 'url'],
-    func: async (_page, args) => {
+    func: async (args) => {
         const term = encodeURIComponent(args.query);
         const limit = Math.max(1, Math.min(Number(args.limit), 25));
         const data = await itunesFetch(`/search?term=${term}&media=podcast&limit=${limit}`);

clis/apple-podcasts/top.js

@@ -14,7 +14,7 @@ cli({
         { name: 'country', default: 'us', help: 'Country code (e.g. us, cn, gb, jp)' },
     ],
     columns: ['rank', 'title', 'author', 'id'],
-    func: async (_page, args) => {
+    func: async (args) => {
         const limit = Math.max(1, Math.min(Number(args.limit), 100));
         const country = String(args.country || 'us').trim().toLowerCase();
         const url = `${CHARTS_URL}/${country}/podcasts/top/${limit}/podcasts.json`;

clis/arxiv/paper.js

@@ -11,7 +11,7 @@ cli({
         { name: 'id', positional: true, required: true, help: 'arXiv paper ID (e.g. 1706.03762)' },
     ],
     columns: ['id', 'title', 'authors', 'published', 'abstract', 'url'],
-    func: async (_page, args) => {
+    func: async (args) => {
         const xml = await arxivFetch(`id_list=${encodeURIComponent(args.id)}`);
         const entries = parseEntries(xml);
         if (!entries.length)

clis/arxiv/search.js

@@ -12,7 +12,7 @@ cli({
         { name: 'limit', type: 'int', default: 10, help: 'Max results (max 25)' },
     ],
     columns: ['id', 'title', 'authors', 'published', 'url'],
-    func: async (_page, args) => {
+    func: async (args) => {
         const limit = Math.max(1, Math.min(Number(args.limit), 25));
         const query = encodeURIComponent(`all:${args.query}`);
         const xml = await arxivFetch(`search_query=${query}&max_results=${limit}&sortBy=relevance`);

clis/bbc/news.js

@@ -12,7 +12,7 @@ cli({
         { name: 'limit', type: 'int', default: 20, help: 'Number of headlines (max 50)' },
     ],
     columns: ['rank', 'title', 'description', 'url'],
-    func: async (page, kwargs) => {
+    func: async (kwargs) => {
         const count = Math.min(kwargs.limit || 20, 50);
         const resp = await fetch('https://feeds.bbci.co.uk/news/rss.xml');
         if (!resp.ok)

clis/bloomberg/businessweek.js

@@ -11,7 +11,7 @@ cli({
         { name: 'limit', type: 'int', default: 1, help: 'Number of feed items to return (max 20)' },
     ],
     columns: ['title', 'summary', 'link', 'mediaLinks'],
-    func: async (_page, kwargs) => {
+    func: async (kwargs) => {
         return fetchBloombergFeed('businessweek', kwargs.limit ?? 1);
     },
 });

clis/bloomberg/economics.js

@@ -11,7 +11,7 @@ cli({
         { name: 'limit', type: 'int', default: 1, help: 'Number of feed items to return (max 20)' },
     ],
     columns: ['title', 'summary', 'link', 'mediaLinks'],
-    func: async (_page, kwargs) => {
+    func: async (kwargs) => {
         return fetchBloombergFeed('economics', kwargs.limit ?? 1);
     },
 });