Skip to content

fix: stabilize manifest paths on Windows#1239

Merged
jackwener merged 1 commit intomainfrom
codex/fix-windows-manifest-stability
May 2, 2026
Merged

fix: stabilize manifest paths on Windows#1239
jackwener merged 1 commit intomainfrom
codex/fix-windows-manifest-stability

Conversation

@jackwener
Copy link
Copy Markdown
Owner

@jackwener jackwener commented May 2, 2026

Summary

  • normalize manifest sourceFile paths to POSIX separators before writing cli-manifest.json
  • centralize manifest serialization and keep cli-manifest.json newline-stable
  • use a Windows junction for directory symlink plugin discovery tests, matching production symlink behavior
  • add regression coverage for manifest path normalization and serialization

Supersedes the still-draft PR #1052 with the same scoped fix on current main.

Verification

  • npx vitest run src/build-manifest.test.ts src/engine.test.ts --project unit
  • npm run typecheck
  • npm run build
  • git diff --check
  • npx vitest run src/build-manifest.test.ts src/engine.test.ts src/cli.test.ts src/diagnostic.test.ts --project unit
  • OPENCLI_DAEMON_PORT=29125 npm test

@jackwener jackwener merged commit c131b4b into main May 2, 2026
11 checks passed
@jackwener jackwener deleted the codex/fix-windows-manifest-stability branch May 2, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant