fix(browser): restart stale ready daemon#1399
Conversation
|
LGTM. Ran browser.test.ts locally on this branch (20/20 pass). The relocated stale check correctly gates all fast-path branches with !staleDaemonReplaced and falls through to spawn when the port releases. Behavior change for stale + profile-required / profile-disconnected (now restarts instead of throwing) is desirable. Nice-to-have (non-blocking): the new test only covers the failure path (shutdown returns false → throws). A happy-path test (shutdown succeeds → port released → fresh daemon spawns) would prove the actual user-visible fix end-to-end, but the existing tests already prove the stale check fires before the ready fast-path return, and the spawn path is shared with the existing no-extension+stale branch — regression risk is low. Residual smoke gap: real-world |
- bump opencli to 1.7.14 (was 1.7.13) - extension stays at 1.0.6 (no extension changes since v1.7.13) - finalize CHANGELOG with the three landed PRs: * #1399 daemon restart on stale ready state for npm -g upgrade * #1400 twitter write-action symmetry (unlike/retweet/unretweet/quote) * #1401 agent-friendly adapter help (drop globally-shared option noise)
Summary\n- check daemon version before the ready fast path in BrowserBridge\n- restart stale daemons even when the extension is already connected\n- add regression coverage for a ready-but-stale daemon\n\n## Test plan\n- npm test -- --run src/browser.test.ts\n- npm run typecheck\n- npm run build\n- git diff --check