fix(douyin): handle empty response body in browserFetch#1408
Open
kagura-agent wants to merge 1 commit intojackwener:mainfrom
Open
fix(douyin): handle empty response body in browserFetch#1408kagura-agent wants to merge 1 commit intojackwener:mainfrom
kagura-agent wants to merge 1 commit intojackwener:mainfrom
Conversation
browserFetch calls res.json() directly, which throws SyntaxError when the API returns an empty body (content-length: 0). This happens when the Douyin hashtag search endpoint returns HTTP 200 with no content. Fix: read response as text first, return null for empty bodies, then throw a descriptive CommandExecutionError at the caller level. Fixes jackwener#1405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
opencli douyin hashtag search --keyword Kingcrashes withSyntaxError: Unexpected end of JSON inputwhen the Douyin API returns HTTP 200 with an empty body (content-length: 0).The root cause is that
browserFetchcallsres.json()directly without checking if the response body is empty.Fix
res.text()), returnnullfor empty bodiesCommandExecutionError('Empty response from Douyin API')instead of an opaque JSON parse errorThis benefits all 20 douyin commands that use
browserFetch.Testing
npx vitest run clis/douyin/✅Closes #1405