Skip to content

fix(browser): handle daemon returning { session, data } wrapper from screenshot #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ddandyy74 wants to merge 1 commit into from
Closed

fix(browser): handle daemon returning { session, data } wrapper from screenshot #1502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/browser/page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,14 +216,18 @@ export class Page extends BasePage {
* Capture a screenshot via CDP Page.captureScreenshot.
*/
async screenshot(options: ScreenshotOptions = {}): Promise<string> {
const base64 = await sendCommand('screenshot', {
const raw = await sendCommand('screenshot', {
...this._cmdOpts(),
format: options.format,
quality: options.quality,
fullPage: options.fullPage,
width: options.width,
height: options.height,
}) as string;
});

const base64 = typeof raw === 'object' && raw !== null && typeof (raw as Record<string, unknown>).data === 'string'
? (raw as Record<string, unknown>).data as string
: raw as string;

if (options.path) {
await saveBase64ToFile(base64, options.path);
Expand Down