refactor(extension): remove lease key session backdoor#1510
Merged
Conversation
jackwener
force-pushed
the
refactor/remove-lease-key-nul-backdoor
branch
from
2d65af6 to
1872f8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
surface\0sessionlease keyssession+surfacefieldssurface\0sessionkeys as extension-internal registry/lease keys onlyVerification
npx vitest run --project extension extension/src/background.test.tsnpm run typecheckcd extension && npm run typecheck && npm run buildnpm run check:typed-error-lintnpm run check:silent-column-dropgit diff --checkNote: I accidentally ran the full
npm test -- --project extension; all 346 files / 3417 tests passed, but Vitest reported an unrelated localEADDRINUSE 127.0.0.1:19825fromsrc/daemon.test.tsbecause my daemon port was already in use. The targeted extension command above passes cleanly.