ci(e2e): drop e2e-headed from pull_request trigger#1521
Merged
Conversation
Per-PR e2e-headed Chrome was the dominant PR-time wait (~10-15 min on two platforms) and on fork PRs blocks behind maintainer approval, while the actually-blocking failures it caught in the last 30 days were all e2e-test migrations missed by the authoring PR (#1461 / #1505 workspace ->session) rather than real regressions the unit/typecheck tier missed. PR feedback path is now: - typecheck / unit / lint / adapter / build ← `pull_request` (ci.yml) - extension typecheck / build ← `pull_request` (build-extension.yml) - docs build ← `pull_request` (doc-check.yml) - security audit ← `pull_request` (security.yml) E2E-headed Chrome guards: - push to main / dev (watched paths) - push v* tag (release) - nightly cron 08:00 UTC (added: catches Chrome version drift / flake drift even when no commits touch watched paths) - workflow_dispatch (manual when a PR really wants e2e signal) smoke-test was already gated on `schedule || workflow_dispatch` only (ci.yml), so no change needed there.
jackwener
added a commit
that referenced
this pull request
May 13, 2026
Per @WAWQAQ direction (DM): trim PR-time CI to fast-feedback only. adapter-test (~30-60s) is the next-largest PR wait after e2e-headed (which #1521 just removed). Adapter authors typically run focused tests locally before pushing (`npm run test:adapter`); CI duplication adds queue latency without catching new classes of bugs. PR-time CI surface now: - typecheck / unit (~1 min) - lint gates (typed-error / silent-column-drop) - build × 3 platforms Adapter test guards (still strict): - push to main / dev - nightly cron - workflow_dispatch (manual when an adapter-heavy PR really wants the signal before merge) Same gate as smoke-test (`if: github.event_name == 'push' || schedule || workflow_dispatch`) for consistency.
3 tasks
jackwener
added a commit
that referenced
this pull request
May 13, 2026
Per @WAWQAQ direction (DM): trim PR-time CI to fast-feedback only. adapter-test (~30-60s) is the next-largest PR wait after e2e-headed (which #1521 just removed). Adapter authors typically run focused tests locally before pushing (`npm run test:adapter`); CI duplication adds queue latency without catching new classes of bugs. PR-time CI surface now: - typecheck / unit (~1 min) - lint gates (typed-error / silent-column-drop) - build × 3 platforms Adapter test guards (still strict): - push to main / dev - nightly cron - workflow_dispatch (manual when an adapter-heavy PR really wants the signal before merge) Same gate as smoke-test (`if: github.event_name == 'push' || schedule || workflow_dispatch`) for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per @WAWQAQ direction (DM): per-PR e2e-headed Chrome (~10-15 min, 2 platforms) is the dominant PR wait, especially on fork PRs where it blocks behind maintainer approval. The actual regressions e2e caught in the last 30 days were e2e-test migrations missed by the authoring PR (#1461 / #1505 workspace→session migration), not real product regressions the unit tier missed.
New PR feedback path
Per-PR (fast, ~2 min):
E2E-headed Chrome guards (still strict):
smoke-test already gated on
schedule || workflow_dispatchonly (ci.yml), no change needed.Test plan
on:block)pushtrigger