Skip to content

fix(extension): keep active daemon websocket#1540

Merged
jackwener merged 2 commits into
jackwener:mainfrom
GreyC:pr/extension-websocket-lifecycle
May 14, 2026
Merged

fix(extension): keep active daemon websocket#1540
jackwener merged 2 commits into
jackwener:mainfrom
GreyC:pr/extension-websocket-lifecycle

Conversation

@GreyC

@GreyC GreyC commented May 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • capture each Browser Bridge WebSocket instance locally so stale close events cannot clear a newer active connection
  • route hello/result/log sends through safeSend() so closing/closed sockets do not throw
  • add extension coverage for a superseded WebSocket closing after a replacement connection is active

Fixes #1537.
Related to #569, #1229, and #1075. This is a small scoped service-worker WebSocket fix and does not replace the broader offscreen-document design in #569.

Verification

  • npm --prefix extension run build
  • npx vitest run --project extension extension/src/background.test.ts
  • npm --prefix extension run typecheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Browser Bridge stale WebSocket close can clobber active daemon connection

2 participants