Skip to content

fix(extension): coalesce daemon websocket connects#1554

Merged
jackwener merged 1 commit into
mainfrom
fix/extension-connect-inflight-lock
May 14, 2026
Merged

fix(extension): coalesce daemon websocket connects#1554
jackwener merged 1 commit into
mainfrom
fix/extension-connect-inflight-lock

Conversation

@jackwener

Copy link
Copy Markdown
Owner

Summary

  • add a Browser Bridge connect in-flight lock so startup / keepalive / reconnect callers share one daemon connection attempt
  • re-check active WebSocket state after async daemon probe and context lookup before constructing a socket
  • add a regression test that repeated keepalive calls during the probe produce only one WebSocket

Fixes #1552

Validation

  • npx vitest run --project extension extension/src/background.test.ts
  • npm --prefix extension run typecheck
  • npm --prefix extension run build
  • git diff --check

@jackwener jackwener merged commit 68b18cd into main May 14, 2026
12 checks passed
@jackwener jackwener deleted the fix/extension-connect-inflight-lock branch May 14, 2026 05:57
@jackwener jackwener mentioned this pull request May 14, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Extension] connect() async gap can create duplicate real WebSocket connections

1 participant