Skip to content

fix(test): bump runCli maxBuffer to fit growing manifest #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackwener merged 2 commits into from
Jun 4, 2026
Merged

fix(test): bump runCli maxBuffer to fit growing manifest #1842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
213621c
fix(test): bump runCli maxBuffer to fit growing manifest
Benjamin-eecs Jun 3, 2026
fec6553
refactor(test): extract DEFAULT_MAX_BUFFER_BYTES constant
Benjamin-eecs Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion tests/e2e/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@ const __dirname = path.dirname(fileURLToPath(import.meta.url));
const ROOT = path.resolve(__dirname, '../..');
const MAIN = path.join(ROOT, 'dist', 'src', 'main.js');

/**
* Default stdout cap for `runCli`. `opencli list -f json` already weighs
* ~1 MB at 1030 entries on v1.8.2 and grows with every new adapter. The
* execFile default maxBuffer is 1 MB; past it stdout overflows and the
* helper returns code 'ERR_CHILD_PROCESS_STDIO_MAXBUFFER' instead of the
* actual exit code.
*/
const DEFAULT_MAX_BUFFER_BYTES = 16 * 1024 * 1024;

export interface CliResult {
stdout: string;
stderr: string;
Expand All @@ -25,14 +34,16 @@ export interface CliResult {
*/
export async function runCli(
args: string[],
opts: { timeout?: number; env?: Record<string, string> } = {},
opts: { timeout?: number; env?: Record<string, string>; maxBuffer?: number } = {},
): Promise<CliResult> {
const timeout = opts.timeout ?? 30_000;
const maxBuffer = opts.maxBuffer ?? DEFAULT_MAX_BUFFER_BYTES;
try {
const runtime = process.env.OPENCLI_TEST_RUNTIME || 'node';
const { stdout, stderr } = await exec(runtime, [MAIN, ...args], {
cwd: ROOT,
timeout,
maxBuffer,
env: {
...process.env,
// Prevent chalk colors from polluting test assertions
Expand Down
Loading