Fix glob pattern matching on Windows#37
Open
maya-maddox wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Glob patterns don't work on Windows. For example:
Expected Behavior
Glob patterns like
src/*or**/testshould match folders on all platforms.Actual Behavior
On Windows, glob patterns never match. Only exact paths (e.g.,
"path": "src/MyProject") work, because they use the.includes()fallback.Root Cause
The relative path is computed using:
rootis a URI path (e.g.,/C:/Users/...)uri.fsPathis a native Windows path (e.g.,C:\Users\...)path.relative()between these two different formats produces an incorrect result on Windows, sominimatchnever matches.Fix
Use
uri.pathinstead ofuri.fsPath, so both paths are in the same URI format.