Fix incorrect formatting of negative numbers#171
Merged
Conversation
The grouping separator was incorrectly applied to negative numbers. This change ensures that the minus sign is not included in the grouping logic, resulting in the correct format for negative values (e.g., `-123,456` instead of `-,123,456`). A regression test for negative numbers has also been added.
Owner
|
Nicely caught! Current state looks horrible 😅 
Thanks for reporting and providing the fix as well 🚀 |
Owner
github-merge-queue Bot
pushed a commit
to infonl/dimpact-zaakafhandelcomponent
that referenced
this pull request
Dec 24, 2025
…5035) This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [nl.jacobras:Human-Readable](https://redirect.github.com/jacobras/human-readable) | `1.12.2` -> `1.12.3` |  |  | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>jacobras/human-readable (nl.jacobras:Human-Readable)</summary> ### [`v1.12.3`](https://redirect.github.com/jacobras/Human-Readable/releases/tag/1.12.3) [Compare Source](https://redirect.github.com/jacobras/human-readable/compare/1.12.2...1.12.3) <!-- Release notes generated using configuration in .github/release.yml at 1.12.3 --> #### What's Changed ##### Dependency Updates 🛠 - Bump kotlin from 2.2.21 to 2.3.0 by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [jacobras/Human-Readable#175](https://redirect.github.com/jacobras/Human-Readable/pull/175) - Bump mikepenz/action-junit-report from 5 to 6 by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [jacobras/Human-Readable#167](https://redirect.github.com/jacobras/Human-Readable/pull/167) - Bump com.vanniktech.maven.publish from 0.34.0 to 0.35.0 by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [jacobras/Human-Readable#168](https://redirect.github.com/jacobras/Human-Readable/pull/168) - Bump actions/checkout from 5 to 6 by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [jacobras/Human-Readable#170](https://redirect.github.com/jacobras/Human-Readable/pull/170) - Bump org.jetbrains.compose from 1.9.2 to 1.9.3 by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [jacobras/Human-Readable#166](https://redirect.github.com/jacobras/Human-Readable/pull/166) ##### Fixes - French: Change decimal symbol from `.` to `,` by [@​soulcramer](https://redirect.github.com/soulcramer) in [jacobras/Human-Readable#174](https://redirect.github.com/jacobras/Human-Readable/pull/174) - All languages: Fix incorrect formatting of negative numbers by [@​jmseb3](https://redirect.github.com/jmseb3) in [jacobras/Human-Readable#171](https://redirect.github.com/jacobras/Human-Readable/pull/171) #### New Contributors - [@​soulcramer](https://redirect.github.com/soulcramer) made their first contribution in [jacobras/Human-Readable#174](https://redirect.github.com/jacobras/Human-Readable/pull/174) - [@​jmseb3](https://redirect.github.com/jmseb3) made their first contribution in [jacobras/Human-Readable#171](https://redirect.github.com/jacobras/Human-Readable/pull/171) **Full Changelog**: <jacobras/Human-Readable@1.12.2...1.12.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/infonl/dimpact-zaakafhandelcomponent). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41OS4wIiwidXBkYXRlZEluVmVyIjoiNDIuNTkuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grouping separator was incorrectly applied to negative numbers. This change ensures that the minus sign is not included in the grouping logic, resulting in the correct format for negative values (e.g.,
-123,456instead of-,123,456).A regression test for negative numbers has also been added.