Use img to load avatars

da2x · da2x · commit 180eb869a1e6 · 2021-12-02T03:44:03.000+01:00
* Stop sending referrer request data to Gravatar (reduces data sharing with Gravatar, improves user privacy).
* Enable lazy loading avatar images (reduces image download request priority, defers downloading off-screen images).
diff --git a/backend/classes/commentsui.php b/backend/classes/commentsui.php
@@ -259,8 +259,11 @@ public function userAvatar ($src = '{src}', $href = '{href}', $text = '{text}')
 
 			if ($this->setup->iconMode !== 'count') {
 				// Create avatar image element
-				$comments_avatar = new HTMLTag ('div', array (
-					'style' => 'background-image: url(\'' . $src . '\');'
+				$comments_avatar = new HTMLTag ('img', array (
+					'src' => $src,
+					'referrerpolicy' => 'no-referrer',
+					'loading' => 'lazy',
+					'alt' => ''
 				), false);
 			} else {
 				// Avatars set to count
diff --git a/backend/classes/formui.php b/backend/classes/formui.php
@@ -257,8 +257,10 @@ protected function avatar ($text)
 			}
 
 			// Create avatar image element
-			$avatar = new HTMLTag ('div', array (
-				'style' => 'background-image: url(\'' . $avatar_src . '\');'
+			$avatar = new HTMLTag ('img', array (
+				'src' => $avatar_src,
+				'alt' => '',
+				'referrerpolicy' => 'no-referrer'
 			), false);
 		} else {
 			// Avatars set to count
diff --git a/themes/default/email-notification.html b/themes/default/email-notification.html
@@ -84,7 +84,7 @@
 	<body>
 		<div id="main">
 			<div id="header">
-				<img id="avatar" src="{avatar}" width="128" height="128" alt="avatar">
+				<img id="avatar" src="{avatar}" width="128" height="128" alt="" referrerpolicy="no-referrer">
 				<p id="name">{name}</p>
 				<p>{domain}</p>
 			</div>
