Skip to content

fix: preserve scroll position in multi-select on option toggle #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
govindarajug wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: preserve scroll position in multi-select on option toggle #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/MenuList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ function MenuList (props) {

const { classNamePrefix, isMulti } = selectProps || {};
const list = React.useRef<List>(null);
const scrollOffsetRef = React.useRef<number>(0);

React.useEffect(
() => {
Expand Down Expand Up @@ -120,10 +121,16 @@ function MenuList (props) {
React.useEffect(
() => {
/**
* enables scrolling on key down arrow
* For multi-select, preserve the scroll position when options are
* selected/deselected so the menu doesn't jump back to the top.
* For single-select, scroll to the focused item on keyboard navigation.
*/
if (currentIndex >= 0 && list.current !== null) {
list.current.scrollToItem(currentIndex);
if (list.current !== null) {
if (isMulti && scrollOffsetRef.current > 0) {
list.current.scrollTo(scrollOffsetRef.current);
} else if (currentIndex >= 0) {
list.current.scrollToItem(currentIndex);
}
}
},
[currentIndex, children, list]
Expand Down Expand Up @@ -151,6 +158,7 @@ function MenuList (props) {
itemCount={itemCount}
itemData={children}
itemSize={index => measuredHeights[index] || heights[index]}
onScroll={({ scrollOffset }) => { scrollOffsetRef.current = scrollOffset; }}
>
{({ data, index, style}: ListChildProps) => {
return (
Expand Down