Skip to content

update extract_into(), add example for bundles and add restart() method#147

Open
hacknus wants to merge 4 commits into
jaemk:masterfrom
hacknus:master
Open

update extract_into(), add example for bundles and add restart() method#147
hacknus wants to merge 4 commits into
jaemk:masterfrom
hacknus:master

Conversation

@hacknus
Copy link
Copy Markdown

@hacknus hacknus commented Jan 18, 2025

Closes #145.

I had to update the extract_into() method such that it works for bundles/directories that are zipped.
Additionally, I added an example in the README.md to describe the usage with bundles (specifically on macOS). For this example, we might consider putting the copy_dir() also in this library, but for now I leave it like that.

Furthermore, I included the restart.rs file with a restart() method that launches a zombie process of the own instance, allowing users to automatically restart the application after self_replace() has been called.

@hacknus
Copy link
Copy Markdown
Author

hacknus commented Mar 14, 2025

Can this be merged?

@hacknus
Copy link
Copy Markdown
Author

hacknus commented May 15, 2025

^bump

# Conflicts:
#	src/lib.rs
@hacknus
Copy link
Copy Markdown
Author

hacknus commented Apr 30, 2026

weird, when I push, the publish workflow is automatically called - which fails in my fork, because I don't have the credentials, obviously. this should probably on run on creating a new release, and not everytime, right?

also, the check_readme failed because I added an example to the readme. you don't allow changes to the readme?

@GideonBear
Copy link
Copy Markdown
Collaborator

GideonBear commented May 1, 2026

weird, when I push, the publish workflow is automatically called - which fails in my fork, because I don't have the credentials, obviously. this should probably on run on creating a new release, and not everytime, right?

@jaemk this is your domain...
In any case, the workflow could probably be limited using if: github.repository == 'jaemk/self_update'

also, the check_readme failed because I added an example to the readme. you don't allow changes to the readme?

We do, but these need to be included in the doc comment in lib.rs and then compiled using cargo-readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Bundles

2 participants