Merge pull request #92 from jagdish-15/add-lint-build

Add lint build

Author: jagdish-15

.github/workflows/java.yml

@@ -42,8 +42,9 @@ jobs:
       - name: Check if changed exercise tests compile cleanly
         run: bin/build-changed-exercise
 
-  lint:
-    name: Lint Java files using Checkstyle
+  lint-all:
+    name: Lint all Java files using Checkstyle
+    if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
@@ -56,6 +57,22 @@ jobs:
         run: ./gradlew check --exclude-task test --continue
         working-directory: exercises
 
+  lint-changed:
+    name: Lint changed Java exercises using Checkstyle
+    if: github.event_name == 'pull_request'
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+        with:
+          fetch-depth: 0
+      - name: Set up JDK 21
+        uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654
+        with:
+          java-version: 21
+          distribution: "temurin"
+      - name: Lint changed exercises
+        run: bin/lint-changed-exercise
+
   test-all:
     name: Test all exercises using java-test-runner
     if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'

bin/build-changed-exercise

@@ -1,29 +1,12 @@
 #!/usr/bin/env bash
 set -eo pipefail
 
-# Determine the base branch of the PR
-BASE_BRANCH=${GITHUB_BASE_REF:-main}
-
-# Fetch full history for proper diff
-git fetch origin "$BASE_BRANCH"
-
-# Compute merge base
-MERGE_BASE=$(git merge-base HEAD origin/"$BASE_BRANCH")
-
-# Get changed files relative to merge base
-changed_files=$(git diff --name-only "$MERGE_BASE" HEAD)
+source "$(dirname "$0")/common.sh"
 
 # If any Gradle build file changed, run the full suite and exit
-if echo "$changed_files" | grep -qE '\.(gradle|gradlew|bat)$|settings\.gradle'; then
-  echo "Gradle build files changed, running full build suite..."
-  cd exercises && ./gradlew compileStarterTestJava --continue
-  exit 0
-fi
-
-# Extract unique exercise directories
-changed_exercises=$(echo "$changed_files" | \
-  grep -E '^exercises/(practice|concept)/[^/]+/.+\.java$' | \
-  cut -d/ -f1-3 | sort -u || true)
+check_gradle_changes \
+  "cd exercises && ./gradlew compileStarterTestJava --continue" \
+  "Gradle build files changed, running full build suite..."
 
 if [ -z "$changed_exercises" ]; then
   echo "No relevant exercises changed, skipping compile checks."

bin/common.sh

@@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+set -eo pipefail
+
+# Determine the base branch of the PR
+BASE_BRANCH=${GITHUB_BASE_REF:-main}
+
+# Fetch full history for proper diff
+git fetch origin "$BASE_BRANCH"
+
+# Compute merge base
+MERGE_BASE=$(git merge-base HEAD origin/"$BASE_BRANCH")
+
+# Get changed files relative to merge base
+changed_files=$(git diff --name-only "$MERGE_BASE" HEAD)
+
+# Function to check if Gradle build files changed and run a command
+check_gradle_changes() {
+  local command="$1"
+  local message="$2"
+  
+  if echo "$changed_files" | grep -qE '\.(gradle|gradlew|bat)$|settings\.gradle'; then
+    echo "$message"
+    eval "$command"
+    exit 0
+  fi
+}
+
+# Extract unique exercise directories
+get_changed_exercises() {
+  echo "$changed_files" | \
+    grep -E '^exercises/(practice|concept)/[^/]+/.+\.java$' | \
+    cut -d/ -f1-3 | sort -u || true
+}
+
+# Variable for reuse
+changed_exercises=$(get_changed_exercises)

bin/lint-changed-exercise

@@ -0,0 +1,37 @@
+#!/usr/bin/env bash
+set -eo pipefail
+
+source "$(dirname "$0")/common.sh"
+
+# If any Gradle build file changed, run the full suite and exit
+check_gradle_changes \
+  "cd exercises && ./gradlew check --exclude-task test --continue" \
+  "Gradle build files changed, running full lint suite..."
+
+if [ -z "$changed_exercises" ]; then
+  echo "No relevant exercises changed, skipping linting."
+  exit 0
+fi
+
+# Print exercises
+echo "Changed exercises detected:"
+echo "$changed_exercises"
+echo "----------------------------------------"
+
+# Run lint checks
+exit_code=0
+for dir in $changed_exercises; do
+  slug=$(basename "$dir")
+
+  echo "========================================"
+  echo "=== Running checkstyle for $slug ==="
+  echo "========================================"
+
+  if [[ $dir == exercises/practice/* ]]; then
+    ./exercises/gradlew -p exercises ":practice:$slug:check" --exclude-task test || exit_code=1
+  elif [[ $dir == exercises/concept/* ]]; then
+    ./exercises/gradlew -p exercises ":concept:$slug:check" --exclude-task test || exit_code=1
+  fi
+done
+
+exit $exit_code

bin/test-changed-exercise

@@ -1,29 +1,12 @@
 #!/usr/bin/env bash
 set -eo pipefail
 
-# Determine the base branch of the PR
-BASE_BRANCH=${GITHUB_BASE_REF:-main}
-
-# Fetch full history for proper diff
-git fetch origin "$BASE_BRANCH"
-
-# Compute merge base
-MERGE_BASE=$(git merge-base HEAD origin/"$BASE_BRANCH")
-
-# Get changed files relative to merge base
-changed_files=$(git diff --name-only "$MERGE_BASE" HEAD)
+source "$(dirname "$0")/common.sh"
 
 # If any Gradle build file changed, run the full suite and exit
-if echo "$changed_files" | grep -qE '\.(gradle|gradlew|bat)$|settings\.gradle'; then
-  echo "Gradle build files changed, running full test suite..."
-  ./bin/test-with-test-runner
-  exit 0
-fi
-
-# Extract unique exercise directories
-changed_exercises=$(echo "$changed_files" | \
-  grep -E '^exercises/(practice|concept)/[^/]+/.+\.java$' | \
-  cut -d/ -f1-3 | sort -u)
+check_gradle_changes \
+  "./bin/test-with-test-runner" \
+  "Gradle build files changed, running full test suite..."
 
 if [ -z "$changed_exercises" ]; then
   echo "No relevant exercises changed, skipping tests."