Fix widget buttons registering clicks twice#230
Merged
jagenjo merged 1 commit intoJun 21, 2021
Conversation
Owner
|
it was to avoid merge issues but its ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes and closes the issue mentioned in #123, which is resulting in buttons registering multiple clicks (once on mouse down, and once on mouse up), but applies the change to the source file and provides new builds.
On a side note, I have only just noticed the updated contribution guidelines asking people not to commit build files. I had committed these changes prior to noticing this though. I'll make sure in the future not to commit build files, if that is still your preference (which makes sense, it'll reduce conflicts a lot)