Fix mouse and trackpad zoom behavior#445
Open
agasy18 wants to merge 2 commits intojagenjo:masterfrom
Open
Conversation
agasy18
commented
Feb 4, 2024
agasy18
commented
- make zoom behavior smooth and friendly
- Tested with MacBook trackpad and Ubuntu mouse works excellent.
* make zoom behavior smooth and friendly * Tested with MacBook trackpad and Ubuntu mouse works excellent.
|
I'm not sure if this one is still appropriate because executeAction was removed. You're welcome to suggest it is and just needs to be elsewhere in code? I'm suspecting I need to switch to using pointer* events but haven't checked yet. |
Author
|
I have tested it, and the change is still actual. |
|
Could this please get merged? Zoom is almost unusable on my system (Ubuntu) which makes it so much harder to work @daniel-lewis-ab |
|
https://github.com/daniel-lewis-ab/litegraph.js on main, Tom. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.