enhance node slot configuration with separate horizontal options for …#521
Open
dserri wants to merge 2 commits into
Open
enhance node slot configuration with separate horizontal options for …#521dserri wants to merge 2 commits into
dserri wants to merge 2 commits into
Conversation
…inputs and outputs
- Updated the logic for determining input and output orientations to allow null values for inputs_horizontal and outputs_horizontal, providing a more flexible configuration. - Adjusted multiple instances in the executeAction method to account for the new null checks, ensuring that the general horizontal property is used when specific orientations are not defined. - Improved documentation comments to clarify the behavior of the new orientation settings.
Owner
|
very promising, can you do the PR only changing the src/litegraph.js ? |
Author
|
@jagenjo i think i have to tinker the code a bit, i found out after some more testing that it is not working as intended. I will take time in the next week to fix the issue then do the PR as you said. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the LiteGraph library, focusing on improving slot orientation flexibility and visual rendering of connections. The key updates include adding separate configuration options for input and output slot orientations, refining the logic for collapsed nodes, and introducing better visual alignment for connections.
Slot Orientation Enhancements:
inputs_horizontalandoutputs_horizontalproperties to allow independent horizontal orientation for input and output slots, overriding the generalhorizontalproperty (build/litegraph.core.js: [1] [2].Rendering and Visual Improvements:
inputs_horizontalandoutputs_horizontalproperties, improving support for collapsed nodes and ensuring consistent alignment (build/litegraph.core.js: [1] [2] [3].build/litegraph.core.js: [1] [2].Codebase Consistency:
horizontalproperty where applicable (build/litegraph.core.js: [1] [2] [3].