Skip to content

Drop support for PHP < 7.4, add return types #23

@tacman

Description

@tacman

I'd like to get rid of the deprecation errors I'm getting now:

2022-02-10T08:00:55-06:00 [info] User Deprecated: Method "Doctrine\DBAL\Types\Type::canRequireSQLConversion()" might add "bool" as a native return type declaration in the future. Do the same in child class "VertigoLabs\DoctrineFullTextPostgres\DBAL\Types\TsVector" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-02-10T08:00:55-06:00 [info] User Deprecated: Method "Doctrine\DBAL\Types\Type::convertToDatabaseValue()" might add "mixed" as a native return type declaration in the future. Do the same in child class "VertigoLabs\DoctrineFullTextPostgres\DBAL\Types\TsVector" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-02-10T08:00:55-06:00 [info] User Deprecated: Method "Doctrine\DBAL\Types\Type::getMappedDatabaseTypes()" might add "array" as a native return type declaration in the future. Do the same in child class "VertigoLabs\DoctrineFullTextPostgres\DBAL\Types\TsVector" now to avoid errors or add an explicit @return annotation to suppress this message.

Fixing these properly would require adding return types, so we'd have to bump up the minimum PHP version. I can do a PR.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions