Make name optional#275
Open
samcragg wants to merge 11 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 4716de2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 502 517 +15
Branches 2 2
=========================================
+ Hits 502 517 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jakebailey
reviewed
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw #214 so thought I'd have a go at implementing it, as I do find the
namea bit redundant but have left it in for compatibility and in case a different display name is wanted to the code (i.e. where it's not a legal typescript identifier)I've tried to modify as little as possible by introducing a
formatTaskNamehelper, however, can look at simplifying things further with probably a bigger refactor.