update composer.json to add phpstan as a dev dependency and define test scripts; refactor GitHub Actions workflow to use new test commands; modify PersistenceInterface and attribute classes to change readonly properties to mutable

Author: jakubkulhan

.github/workflows/test.yaml

@@ -8,7 +8,17 @@ jobs:
         with:
           php-version: '8.3'
       - uses: php-actions/composer@v6
-      - run: ./vendor/bin/phpunit --group unit
+      - run: composer test:unit
+
+  test-phpstan:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.3'
+      - uses: php-actions/composer@v6
+      - run: composer test:phpstan
 
   test-database:
     runs-on: ubuntu-latest
@@ -41,4 +51,6 @@ jobs:
         with:
           php-version: '8.3'
       - uses: php-actions/composer@v6
-      - run: DATABASE_URL=${{ matrix.database.database_url }} ./vendor/bin/phpunit --group database
+      - run: composer test:database
+        env:
+          DATABASE_URL: ${{ matrix.database.database_url }}

composer.json

@@ -7,7 +7,8 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^11.1",
-        "spatie/phpunit-snapshot-assertions": "^5.1"
+        "spatie/phpunit-snapshot-assertions": "^5.1",
+        "phpstan/phpstan": "^2.1.17"
     },
     "repositories": [
         {
@@ -26,5 +27,10 @@
             "DataAccessKit\\": "data-access-kit/test/",
             "DataAccessKit\\Symfony\\": "data-access-kit-symfony/test/"
         }
+    },
+    "scripts": {
+        "test:unit": "./vendor/bin/phpunit --group unit",
+        "test:database": "./vendor/bin/phpunit --group database",
+        "test:phpstan": "./vendor/bin/phpstan analyse data-access-kit/src data-access-kit-symfony/src --memory-limit=512M"
     }
 }

data-access-kit/src/Attribute/Column.php

@@ -8,7 +8,7 @@
 #[Attribute(Attribute::TARGET_PROPERTY)]
 class Column
 {
-	public readonly ReflectionProperty $reflection;
+	public ReflectionProperty $reflection;
 
 	public function __construct(
 		public ?string $name = null,

data-access-kit/src/Attribute/Table.php

@@ -8,10 +8,10 @@
 #[Attribute(Attribute::TARGET_CLASS)]
 class Table
 {
-	public readonly ReflectionClass $reflection;
+	public ReflectionClass $reflection;
 
 	/** @var Column[] */
-	public readonly array $columns;
+	public array $columns;
 
 	public function __construct(
 		public ?string $name = null,

data-access-kit/src/PersistenceInterface.php

@@ -36,16 +36,14 @@ public function execute(string $sql, array $parameters = []): int;
 	/**
 	 * Insert data into the database.
 	 *
-	 * @template T
-	 * @param T|T[] $data
+	 * @param object|array $data
 	 */
 	public function insert(object|array $data): void;
 
 	/**
 	 * Insert or update data in the database.
 	 *
-	 * @template T
-	 * @param T|T[] $data
+	 * @param object|array $data
 	 */
 	public function upsert(object|array $data, ?array $columns = null): void;
 
@@ -57,8 +55,7 @@ public function update(object $data, ?array $columns = null): void;
 	/**
 	 * Delete data from the database based on its primary key.
 	 *
-	 * @template T
-	 * @param T|T[] $data
+	 * @param object|array $data
 	 */
 	public function delete(object|array $data): void;
 

data-access-kit/src/Repository/ResultMethod.php

@@ -11,7 +11,7 @@
 class ResultMethod implements Stringable
 {
 
-	public readonly ReflectionMethod $reflection;
+	public ReflectionMethod $reflection;
 
 	private string $visibility = "public";
 	/** @var array<string, ResultParameter> */