Comments#21
Open
casakawa-jama wants to merge 2 commits into
Open
Conversation
nmchale-jama
reviewed
Mar 8, 2021
| Returns: A single comment | ||
| """ | ||
| resource_path = 'comments/' + str(comment_id) | ||
| comments = self.__get_all(resource_path) |
Contributor
There was a problem hiding this comment.
This should be a single entity fetch
nmchale-jama
reviewed
Mar 8, 2021
| baseline_items = self.__get_all(resource_path) | ||
| return baseline_items | ||
|
|
||
| def get_comments(self): |
Contributor
There was a problem hiding this comment.
Lets add a boolean param for rootCommentsOnly
nmchale-jama
reviewed
Mar 8, 2021
| JamaClient.__handle_response_status(response) | ||
| return response.json()['meta']['id'] | ||
|
|
||
| def post_comment(self, item_id: int, message: str, in_reply_to: int = None): |
Contributor
There was a problem hiding this comment.
Need param to post to item or project. we should also add a field for comment type
nmchale-jama
suggested changes
Mar 8, 2021
nmchale-jama
left a comment
nmchale-jama
left a comment
Contributor
There was a problem hiding this comment.
See comments for requested updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements GET all comments endpoint