Switch to JDK HTTP Client

Fixes #480

Author: jamesnetherton

pom.xml

@@ -17,7 +17,6 @@
         <project.build.reportEncoding>UTF-8</project.build.reportEncoding>
 
         <!-- Project dependency versions -->
-        <httpcomponents.version>5.6</httpcomponents.version>
         <jackson.version>2.21.1</jackson.version>
 
         <!-- Project test dependency versions -->
@@ -91,12 +90,6 @@
             <groupId>com.fasterxml.jackson.datatype</groupId>
             <artifactId>jackson-datatype-jsr310</artifactId>
         </dependency>
-        <dependency>
-            <groupId>org.apache.httpcomponents.client5</groupId>
-            <artifactId>httpclient5</artifactId>
-            <version>${httpcomponents.version}</version>
-        </dependency>
-
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter</artifactId>

src/main/java/com/github/jamesnetherton/zulip/client/http/ZulipConfiguration.java

@@ -1,6 +1,6 @@
 package com.github.jamesnetherton.zulip.client.http;
 
-import com.github.jamesnetherton.zulip.client.http.commons.ZulipCommonsHttpClientFactory;
+import com.github.jamesnetherton.zulip.client.http.jdk.ZulipJdkHttpClientFactory;
 import com.github.jamesnetherton.zulip.client.util.ZulipUrlUtils;
 import java.io.File;
 import java.io.IOException;
@@ -21,7 +21,7 @@ public class ZulipConfiguration {
     private URL proxyUrl;
     private String proxyUsername;
     private String proxyPassword;
-    private ZulipHttpClientFactory zulipHttpClientFactory = new ZulipCommonsHttpClientFactory();
+    private ZulipHttpClientFactory zulipHttpClientFactory = new ZulipJdkHttpClientFactory();
     private URL zulipUrl;
 
     /**

src/main/java/com/github/jamesnetherton/zulip/client/http/ZulipHttpClientFactory.java

@@ -5,7 +5,7 @@
 /**
  * Factory class for creating {@link ZulipHttpClient} implementations.
  *
- * Provides a way to use HTTP client libraries other than the default Apache Commons HTTP Client.
+ * Provides a way to use HTTP client libraries other than the default JDK HTTP Client.
  */
 public interface ZulipHttpClientFactory {
     ZulipHttpClient createZulipHttpClient(ZulipConfiguration configuration) throws ZulipClientException;