(dev): Update and improve linting infrastructure (valkey-io#104)

- Improve scripts (separate languages and allow fixing).
- Update configuration (remove unnecessary exclusions)
- Consistent versioning (don't use different versions locally and in CI).
- Consistent behaviour (use same script locally and in CI)
- Git hook and hook installation script.
- Improved documentation

Signed-off-by: currantw <taylor.curran@improving.com>

Author: currantw

.github/workflows/lint-rust/action.yml

@@ -15,7 +15,6 @@ on:
       - .github/workflows/install-shared-dependencies/action.yml
       - .github/workflows/build-php-wrapper/action.yml
       - .github/workflows/test-benchmark/action.yml
-      - .github/workflows/lint-rust/action.yml
       - .github/workflows/install-engine/action.yml
       - .github/workflows/create-test-matrices/action.yml
       - .github/json_matrices/**
@@ -29,7 +28,6 @@ on:
       - .github/workflows/install-shared-dependencies/action.yml
       - .github/workflows/build-php-wrapper/action.yml
       - .github/workflows/test-benchmark/action.yml
-      - .github/workflows/lint-rust/action.yml
       - .github/workflows/install-engine/action.yml
       - .github/workflows/create-test-matrices/action.yml
       - .github/json_matrices/**
@@ -842,13 +840,13 @@ jobs:
               libtool \
               pkg-config \
               libssl-dev \
-              clang-format \
               protobuf-c-compiler \
               libprotobuf-c-dev \
               libprotobuf-c1
 
-      - name: Check clang-format version
-        run: clang-format --version
+          # Install clang-format-18 and set it as default.
+          sudo apt-get install -y clang-format-18
+          sudo update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-18 100
 
       - name: Install protoc
         uses: ./.github/workflows/install-rust-and-protoc
@@ -890,15 +888,9 @@ jobs:
         run: |
           ./configure --enable-valkey-glide --disable-header-generation
 
-      - name: Lint C code formatting
+      - name: Run linters
         run: |
-          find . -name "*.c" -o -name "*.h" | grep -v "\.pb-c\." | xargs clang-format --dry-run --Werror
-
-      - name: Lint PHP code (if PHP files exist)
-        run: |
-          if find tests/ -name "*.php" | head -1 | grep -q .; then
-              phpcs . || true
-          fi
+          ./lint.sh
 
   get-containers:
     runs-on: ubuntu-latest

.github/workflows/php.yml

@@ -109,11 +109,21 @@ Use conventional commit format:
 
 ### Code Quality Requirements
 
-**C Linters:**
-Run clang-format on any modified .c and .h files.
+#### Running Linters
 
-**PHP Linters:**
-To be added.
+```bash
+# All linters
+./lint.sh            # Check
+./lint.sh --fix      # Fix
+
+# C code only
+./lint-c.sh          # Check
+./lint-c.sh --fix    # Fix
+
+# PHP code only
+./lint-php.sh        # Check
+./lint-php.sh --fix  # Fix
+```
 
 ## Guardrails & Policies
 
@@ -123,13 +133,12 @@ See the .gitignore
 ## Quality Gates (Agent Checklist)
 
 - [ ] Build passes: `phpize, ./configure, make` succeeds
-- [ ] All tests pass: `make install` succeeds
-- [ ] Linting passes: `clang-format` does not report warnings on changed .c or .h files
+- [ ] All tests pass: `make test` succeeds
+- [ ] Linting passes: `./lint.sh` does not report warnings
 - [ ] No generated outputs committed (check `.gitignore`)
 - [ ] DCO signoff present: `git log --format="%B" -n 1 | grep "Signed-off-by"`
 - [ ] Conventional commit format used
 - [ ] Documentation follows Google Style format
-- [ ] Shared logic properly isolated in `glide-shared/`
 
 ## Quick Facts for Reasoners
 

.vscode/settings.json

@@ -42,6 +42,12 @@ See the [Valkey installation guide](https://valkey.io/topics/installation/) to i
 ```bash
 sudo apt update -y
 sudo apt install -y php-dev php-cli git gcc make autotools-dev libtool pkg-config openssl libssl-dev unzip libprotobuf-c-dev libprotobuf-c1
+
+# Install clang-format-18 and ensure clang-format points to it.
+sudo apt install -y clang-format-18
+sudo update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-18 100
+clang-format --version  # Version 18.x
+
 # Install rust
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
 source "$HOME/.cargo/env"
@@ -74,6 +80,12 @@ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
 source "$HOME/.cargo/env"
 # Check that the Rust compiler is installed
 rustc --version
+
+# Install clang-format-18 and update PATH to point to it.
+brew install llvm@18
+echo 'export PATH="/opt/homebrew/opt/llvm@18/bin:$PATH"' >> ~/.zshrc
+source ~/.zshrc
+clang-format --version  # Should show version 18.x
 ```
 
 **Install protobuf compiler**
@@ -263,24 +275,33 @@ php -n -d extension=../modules/valkey_glide.so TestValkeyGlide.php
 
 Development on the PHP wrapper involves changes in both C and PHP code. We have comprehensive linting infrastructure to ensure code quality and consistency. All linting checks are automatically run in our GitHub Actions CI pipeline.
 
-#### Language-specific Linters
+- `clang-format` - C code formatting with Google-based style. Configured by `.clang-format`.
+- `phpcs` (PHP_CodeSniffer) - enforces PHP code standards. Configured by `phpcs.xml`.
+- `phpcbf` (PHP Code Beautifier and Fixer) - corrects PHP code standards. Configured by `phpcs.xml`.
 
-**C Code:**
-- **clang-format**: Code formatting with Google-based style (4-space indentation, 100-char line limit)
-- **valgrind**: Memory leak detection during testing
+#### Running Linters
+
+```bash
+# All linters
+./lint.sh            # Check
+./lint.sh --fix      # Fix
 
-**PHP Code:**
-- **PHP_CodeSniffer (phpcs)**:  coding standards.
-- **PHP Code Beautifier (phpcbf)**: Automatic code formatting
+# C code only
+./lint-c.sh          # Check
+./lint-c.sh --fix    # Fix
 
+# PHP code only
+./lint-php.sh        # Check
+./lint-php.sh --fix  # Fix
+```
 
-#### Linting Configuration Files
+#### Git Hooks
 
-The project includes comprehensive linting configuration:
+Install the pre-commit hook to automatically run linters before each commit:
 
-- **`phpcs.xml`**: PHP_CodeSniffer configuration with PSR-12 standards
-- **`.clang-format`**: C code formatting rules (Google-based style)
-- **`composer.json`**: Development dependencies and linting scripts
+```bash
+./git_hooks/install-git-hooks.sh
+```
 
 #### IDE Integration
 
@@ -291,8 +312,6 @@ VSCode is configured to automatically use the project's linting tools:
 - Integration with project-specific linting configurations
 - Extensions recommended: PHP, C/C++, phpcs, phpstan, clangd
 
-
-
 ### Extension Development Guidelines
 
 #### PHP Extension Conventions

AGENTS.md

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace ValkeyGlide\OpenTelemetry;
 
 /**

DEVELOPER.md

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace ValkeyGlide\OpenTelemetry;
 
 use ValkeyGlideException;

MetricsConfig.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace ValkeyGlide\OpenTelemetry;
 
 /**

MetricsConfigBuilder.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace ValkeyGlide\OpenTelemetry;
 
 use ValkeyGlideException;

OpenTelemetryConfig.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace ValkeyGlide\OpenTelemetry;
 
 /**