Address GUI PR feedback

Author: jamesyc

macos/TimeCapsuleSMB/Sources/TimeCapsuleSMBApp/ActivityStore.swift

@@ -20,7 +20,7 @@ final class ActivityStore: ObservableObject {
     @Published private(set) var snapshot = ActivitySnapshot(
         isRunning: false,
         scope: .unknown,
-        operationTitle: "No active operation",
+        operationTitle: L10n.string("activity.no_active_operation"),
         latestMessage: nil,
         timeline: []
     )
@@ -86,7 +86,8 @@ final class ActivityStore: ObservableObject {
         snapshot = ActivitySnapshot(
             isRunning: coordinator.backend.isRunning,
             scope: scope,
-            operationTitle: operation.map(OperationTimelineBuilder.operationTitle) ?? (timeline.isEmpty ? "No active operation" : "Last operation"),
+            operationTitle: operation.map(OperationTimelineBuilder.operationTitle)
+                ?? (timeline.isEmpty ? L10n.string("activity.no_active_operation") : L10n.string("activity.last_operation")),
             latestMessage: latestMessage,
             timeline: timeline
         )

macos/TimeCapsuleSMB/Sources/TimeCapsuleSMBApp/AppReadinessStore.swift

@@ -9,6 +9,25 @@ enum AppReadinessStateKind: String, CaseIterable, Equatable {
     case ready
     case degraded
     case blocked
+
+    var title: String {
+        switch self {
+        case .idle:
+            return L10n.string("app_readiness.state.idle")
+        case .resolvingBundle:
+            return L10n.string("app_readiness.state.resolving_bundle")
+        case .checkingCapabilities:
+            return L10n.string("app_readiness.state.checking_capabilities")
+        case .validatingInstall:
+            return L10n.string("app_readiness.state.validating_install")
+        case .ready:
+            return L10n.string("app_readiness.state.ready")
+        case .degraded:
+            return L10n.string("app_readiness.state.degraded")
+        case .blocked:
+            return L10n.string("app_readiness.state.blocked")
+        }
+    }
 }
 
 struct AppReadinessSummary: Equatable {
@@ -134,7 +153,7 @@ final class AppReadinessStore: ObservableObject {
                 code: .helperMissing,
                 severity: .error,
                 message: error.localizedDescription,
-                recovery: "Reinstall TimeCapsuleSMB or choose a valid helper in Diagnostics."
+                recovery: L10n.string("app_readiness.recovery.helper_missing")
             ))
             return
         }
@@ -205,7 +224,7 @@ final class AppReadinessStore: ObservableObject {
                     code: .operationFailed,
                     severity: .error,
                     message: payload.summary,
-                    recovery: "Open Diagnostics and retry app readiness."
+                    recovery: L10n.string("app_readiness.recovery.retry_diagnostics")
                 ))
                 return
             }
@@ -225,7 +244,7 @@ final class AppReadinessStore: ObservableObject {
                     code: .installValidationFailed,
                     severity: .error,
                     message: payload.summary,
-                    recovery: "Reinstall TimeCapsuleSMB or open Diagnostics for the failed checks."
+                    recovery: L10n.string("app_readiness.recovery.install_validation_failed")
                 ))
                 return
             }
@@ -272,16 +291,16 @@ final class AppReadinessStore: ObservableObject {
             code: code,
             severity: .error,
             message: event.message ?? event.summary,
-            recovery: BackendErrorViewModel(event: event).recovery?.message ?? "Open Diagnostics and retry app readiness."
+            recovery: BackendErrorViewModel(event: event).recovery?.message ?? L10n.string("app_readiness.recovery.retry_diagnostics")
         )
     }
 
     private func contractIssue(operation: String, error: Error) -> BundleRuntimeIssue {
         BundleRuntimeIssue(
             code: .contractDecodeFailed,
             severity: .error,
-            message: "\(operation) returned an unexpected payload: \(error.localizedDescription)",
-            recovery: "Update or reinstall TimeCapsuleSMB so the app and helper use the same API contract."
+            message: L10n.format("app_readiness.error.unexpected_payload", operation, error.localizedDescription),
+            recovery: L10n.string("app_readiness.recovery.contract_mismatch")
         )
     }
 

macos/TimeCapsuleSMB/Sources/TimeCapsuleSMBApp/BackendClient.swift

@@ -24,6 +24,10 @@ final class BackendClient: ObservableObject {
         self.helperPath = helperPath
     }
 
+    deinit {
+        runTask?.cancel()
+    }
+
     func clear() {
         guard !isRunning else {
             return

macos/TimeCapsuleSMB/Sources/TimeCapsuleSMBApp/BackendPayloads.swift

@@ -672,6 +672,7 @@ struct BackendRecoveryPayload: Decodable, Equatable {
     let title: String
     let message: String?
     let actions: [String]
+    let actionIDs: [String]
     let retryable: Bool
     let suggestedOperation: String?
     let docsAnchor: String?
@@ -680,8 +681,20 @@ struct BackendRecoveryPayload: Decodable, Equatable {
         case title
         case message
         case actions
+        case actionIDs = "action_ids"
         case retryable
         case suggestedOperation = "suggested_operation"
         case docsAnchor = "docs_anchor"
     }
+
+    init(from decoder: Decoder) throws {
+        let container = try decoder.container(keyedBy: CodingKeys.self)
+        self.title = try container.decode(String.self, forKey: .title)
+        self.message = try container.decodeIfPresent(String.self, forKey: .message)
+        self.actions = try container.decodeIfPresent([String].self, forKey: .actions) ?? []
+        self.actionIDs = try container.decodeIfPresent([String].self, forKey: .actionIDs) ?? []
+        self.retryable = try container.decode(Bool.self, forKey: .retryable)
+        self.suggestedOperation = try container.decodeIfPresent(String.self, forKey: .suggestedOperation)
+        self.docsAnchor = try container.decodeIfPresent(String.self, forKey: .docsAnchor)
+    }
 }