Remove stale Bonjour link-local IPv4 doctor warning

Author: jamesyc

src/timecapsulesmb/checks/bonjour.py

@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-import ipaddress
 from dataclasses import dataclass
 
 from timecapsulesmb.checks.models import CheckResult
@@ -224,30 +223,3 @@ def check_bonjour_host_ip(
     if known_ips:
         return CheckResult("PASS", f"resolved Bonjour host {hostname} to {', '.join(known_ips)}")
     return CheckResult("FAIL", f"could not resolve Bonjour host {hostname}")
-
-
-def check_bonjour_host_link_local_ips(
-    hostname: str,
-    *,
-    expected_ip: str | None = None,
-    record_ips: list[str] | None = None,
-) -> CheckResult | None:
-    if not expected_ip:
-        return None
-
-    link_local_ips: list[str] = []
-    for ip in record_ips or []:
-        try:
-            parsed_ip = ipaddress.ip_address(ip)
-        except ValueError:
-            continue
-        if parsed_ip.version == 4 and parsed_ip.is_link_local and ip not in link_local_ips:
-            link_local_ips.append(ip)
-
-    if not link_local_ips:
-        return None
-
-    return CheckResult(
-        "WARN",
-        f"Bonjour host {hostname} also advertised link-local IPv4 {', '.join(link_local_ips)}; clients may have stale mDNS cache",
-    )

src/timecapsulesmb/checks/doctor_steps.py

@@ -7,7 +7,6 @@
     BonjourServiceTarget,
     build_bonjour_expected_identity,
     check_bonjour_host_ip,
-    check_bonjour_host_link_local_ips,
     check_smb_instance,
     check_smb_service_target,
     discover_smb_services_detailed,
@@ -249,16 +248,6 @@ def _add_bonjour_host_ip_results(
         record_ips=record_ips,
     )
     add_result(host_ip_result)
-    if host_ip_result.status != "PASS":
-        return
-
-    link_local_result = check_bonjour_host_link_local_ips(
-        hostname,
-        expected_ip=expected_ip,
-        record_ips=record_ips,
-    )
-    if link_local_result is not None:
-        add_result(link_local_result)
 
 
 def _add_bonjour_results(

tests/test_checks.py

@@ -20,7 +20,6 @@
 from timecapsulesmb.checks.bonjour import (
     build_bonjour_expected_identity,
     check_bonjour_host_ip,
-    check_bonjour_host_link_local_ips,
     check_smb_instance,
     check_smb_service_target,
     discover_smb_services_detailed,
@@ -707,7 +706,7 @@ def test_run_doctor_checks_uses_ip_only_bonjour_fallback_when_runtime_name_probe
         self.assertTrue(any(result.status == "WARN" and "runtime naming identity probe skipped: probe failed" in result.message for result in run.results))
         self.assertTrue(any(result.status == "PASS" and "discovered _smb._tcp service matching target IP 10.0.0.2" in result.message for result in run.results))
 
-    def test_run_doctor_checks_warns_when_bonjour_record_includes_link_local_ip(self) -> None:
+    def test_run_doctor_checks_accepts_bonjour_record_with_link_local_ip(self) -> None:
         instance = BonjourServiceInstance(
             service_type="_smb._tcp.local.",
             name="Time Capsule Samba 4",
@@ -734,8 +733,14 @@ def test_run_doctor_checks_warns_when_bonjour_record_includes_link_local_ip(self
         self.assertFalse(run.fatal)
         self.assertTrue(
             any(
-                result.status == "WARN"
-                and "Bonjour host timecapsulesamba4.local also advertised link-local IPv4 169.254.44.9" in result.message
+                result.status == "PASS"
+                and "resolved Bonjour host timecapsulesamba4.local to 10.0.0.2" in result.message
+                for result in run.results
+            )
+        )
+        self.assertFalse(
+            any(
+                "also advertised link-local IPv4" in result.message or "stale mDNS cache" in result.message
                 for result in run.results
             )
         )
@@ -1032,34 +1037,6 @@ def test_check_bonjour_host_ip_fails_when_dns_resolves_wrong_ip(self) -> None:
         self.assertEqual(result.status, "FAIL")
         self.assertIn("expected 10.0.1.1", result.message)
 
-    def test_check_bonjour_host_link_local_ips_returns_none_for_lan_only(self) -> None:
-        result = check_bonjour_host_link_local_ips(
-            "home.local",
-            expected_ip="10.0.1.1",
-            record_ips=["10.0.1.1"],
-        )
-        self.assertIsNone(result)
-
-    def test_check_bonjour_host_link_local_ips_warns_for_link_local_extra_ip(self) -> None:
-        result = check_bonjour_host_link_local_ips(
-            "home.local",
-            expected_ip="10.0.1.1",
-            record_ips=["10.0.1.1", "169.254.44.9"],
-        )
-        self.assertIsNotNone(result)
-        assert result is not None
-        self.assertEqual(result.status, "WARN")
-        self.assertIn("169.254.44.9", result.message)
-        self.assertIn("stale mDNS cache", result.message)
-
-    def test_check_bonjour_host_link_local_ips_ignores_non_link_local_extra_ip(self) -> None:
-        result = check_bonjour_host_link_local_ips(
-            "home.local",
-            expected_ip="10.0.1.1",
-            record_ips=["10.0.1.1", "10.0.1.2"],
-        )
-        self.assertIsNone(result)
-
     def test_try_authenticated_smb_listing_handles_timeout(self) -> None:
         with mock.patch("timecapsulesmb.checks.smb.command_exists", return_value=True):
             with mock.patch(