Skip to content

refactor: remove debug console.log statements from hot-path components #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neuron-tech-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove debug console.log statements from hot-path components #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions app/src/components/ServerSettings/ModelProgress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ export function ModelProgress({
return;
}

console.log(`[ModelProgress] Connecting SSE for ${modelName}`);

// Subscribe to progress updates via Server-Sent Events
const eventSource = new EventSource(`${serverUrl}/models/progress/${modelName}`);

Expand All @@ -40,21 +38,18 @@ export function ModelProgress({

// Close connection if complete or error
if (data.status === 'complete' || data.status === 'error') {
console.log(`[ModelProgress] Download ${data.status} for ${modelName}, closing SSE`);
eventSource.close();
}
} catch (error) {
console.error('Error parsing progress event:', error);
} catch {
// Ignore malformed SSE frames
}
};

eventSource.onerror = (error) => {
console.error(`[ModelProgress] SSE error for ${modelName}:`, error);
eventSource.onerror = () => {
eventSource.close();
};

return () => {
console.log(`[ModelProgress] Cleanup - closing SSE for ${modelName}`);
eventSource.close();
};
}, [serverUrl, modelName, isDownloading]);
Expand Down
10 changes: 1 addition & 9 deletions app/src/lib/api/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,18 +561,10 @@ class ApiClient {
}

async triggerModelDownload(modelName: string): Promise<{ message: string }> {
console.log(
'[API] triggerModelDownload called for:',
modelName,
'at',
new Date().toISOString(),
);
const result = await this.request<{ message: string }>('/models/download', {
return this.request<{ message: string }>('/models/download', {
method: 'POST',
body: JSON.stringify({ model_name: modelName } as ModelDownloadRequest),
});
console.log('[API] triggerModelDownload response:', result);
return result;
}

async deleteModel(modelName: string): Promise<{ message: string }> {
Expand Down
28 changes: 1 addition & 27 deletions app/src/lib/hooks/useModelDownloadToast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,10 @@ export function useModelDownloadToast({
}, []);

useEffect(() => {
console.log('[useModelDownloadToast] useEffect triggered', {
enabled,
serverUrl,
modelName,
displayName,
});

if (!enabled || !serverUrl || !modelName) {
console.log('[useModelDownloadToast] Not enabled, skipping');
return;
}

console.log('[useModelDownloadToast] Creating toast and EventSource for:', modelName);

// Create initial toast
const toastResult = toast({
title: displayName,
Expand All @@ -70,15 +60,9 @@ export function useModelDownloadToast({

// Subscribe to progress updates via Server-Sent Events
const eventSourceUrl = `${serverUrl}/models/progress/${modelName}`;
console.log('[useModelDownloadToast] Creating EventSource to:', eventSourceUrl);
const eventSource = new EventSource(eventSourceUrl);

eventSource.onopen = () => {
console.log('[useModelDownloadToast] EventSource connection opened for:', modelName);
};

eventSource.onmessage = (event) => {
console.log('[useModelDownloadToast] Received SSE message:', event.data);
try {
const progress = JSON.parse(event.data) as ModelProgress;

Expand Down Expand Up @@ -141,11 +125,6 @@ export function useModelDownloadToast({
const isError = progress.status === 'error';

if (isComplete || isError) {
console.log('[useModelDownloadToast] Download finished:', {
isComplete,
isError,
progress: progress.progress,
});
eventSource.close();
eventSourceRef.current = null;

Expand All @@ -165,10 +144,8 @@ export function useModelDownloadToast({

// Call callbacks
if (isComplete && onComplete) {
console.log('[useModelDownloadToast] Download complete, calling onComplete callback');
onComplete();
} else if (isError && onError) {
console.log('[useModelDownloadToast] Download error, calling onError callback');
onError(progress.error || 'Unknown error');
}
}
Expand All @@ -178,9 +155,7 @@ export function useModelDownloadToast({
}
};

eventSource.onerror = (error) => {
console.error('[useModelDownloadToast] SSE error for:', modelName, error);
console.log('[useModelDownloadToast] EventSource readyState:', eventSource.readyState);
eventSource.onerror = () => {
eventSource.close();
eventSourceRef.current = null;

Expand All @@ -201,7 +176,6 @@ export function useModelDownloadToast({

// Cleanup on unmount or when disabled
return () => {
console.log('[useModelDownloadToast] Cleanup - closing EventSource for:', modelName);
if (eventSourceRef.current) {
eventSourceRef.current.close();
eventSourceRef.current = null;
Expand Down
38 changes: 3 additions & 35 deletions app/src/lib/hooks/useStoryPlayback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ export function useStoryPlayback(items: StoryItemDetail[] | undefined) {
const getAudioContext = useCallback(() => {
if (!audioContextRef.current) {
audioContextRef.current = new AudioContext();
console.log(
'[StoryPlayback] Created AudioContext, sample rate:',
audioContextRef.current.sampleRate,
);

// Create master gain node for volume control
masterGainRef.current = audioContextRef.current.createGain();
Expand Down Expand Up @@ -123,31 +119,22 @@ export function useStoryPlayback(items: StoryItemDetail[] | undefined) {
const key = getAudioKey(item);
if (!audioBuffersRef.current.has(key)) {
const audioUrl = getAudioUrlForItem(item);
console.log('[StoryPlayback] Preloading audio buffer:', key);

const preloadPromise = fetch(audioUrl)
.then((response) => response.arrayBuffer())
.then((arrayBuffer) => audioContext.decodeAudioData(arrayBuffer))
.then((audioBuffer) => {
audioBuffersRef.current.set(key, audioBuffer);
console.log(
'[StoryPlayback] Preloaded buffer:',
key,
'duration:',
audioBuffer.duration,
);
})
.catch((err) => {
console.error('[StoryPlayback] Failed to preload audio:', key, err);
.catch(() => {
// Failed to preload — item will be skipped during playback
});

preloadPromises.push(preloadPromise);
}
}

Promise.all(preloadPromises).then(() => {
console.log('[StoryPlayback] Preloaded', audioBuffersRef.current.size, 'audio buffers');
});
Promise.all(preloadPromises);
}, [items, getAudioContext]);

// Cleanup AudioContext on unmount
Expand Down Expand Up @@ -219,7 +206,6 @@ export function useStoryPlayback(items: StoryItemDetail[] | undefined) {

// Stop all sources
const stopAllSources = useCallback(() => {
console.log('[StoryPlayback] Stopping all sources');
for (const [itemId] of activeSourcesRef.current) {
stopSource(itemId);
}
Expand Down Expand Up @@ -249,7 +235,6 @@ export function useStoryPlayback(items: StoryItemDetail[] | undefined) {
const bufferKey = getAudioKey(item);
const buffer = audioBuffersRef.current.get(bufferKey);
if (!buffer) {
console.warn('[StoryPlayback] Buffer not loaded for:', bufferKey);
continue;
}

Expand All @@ -271,16 +256,6 @@ export function useStoryPlayback(items: StoryItemDetail[] | undefined) {
// If the item should have already started, schedule it to start immediately
const startAtContextTime = Math.max(currentContextTime, itemStartContextTime);

console.log('[StoryPlayback] Scheduling source:', {
itemId: item.id,
generationId: item.generation_id,
storyTimeMs,
itemStart: item.start_time_ms,
offsetIntoBuffer,
startAtContextTime,
duration,
});

const source = audioContext.createBufferSource();
source.buffer = buffer;
// Per-clip gain so each item can override its level independently
Expand All @@ -307,7 +282,6 @@ export function useStoryPlayback(items: StoryItemDetail[] | undefined) {

// Clean up when source ends
source.onended = () => {
console.log('[StoryPlayback] Source ended:', item.id);
activeSourcesRef.current.delete(item.id);
};
}
Expand Down Expand Up @@ -348,7 +322,6 @@ export function useStoryPlayback(items: StoryItemDetail[] | undefined) {
if (currentStoryTime >= totalDuration) {
// Check if all sources have ended
if (activeSourcesRef.current.size === 0) {
console.log('[StoryPlayback] Reached end');
useStoryStore.getState().stop();
return;
}
Expand Down Expand Up @@ -385,7 +358,6 @@ export function useStoryPlayback(items: StoryItemDetail[] | undefined) {
// Handle play/pause changes - stop sources when paused
useEffect(() => {
if (!isPlaying) {
console.log('[StoryPlayback] Stopping playback');
stopAllSources();
}
}, [isPlaying, stopAllSources]);
Expand All @@ -405,10 +377,6 @@ export function useStoryPlayback(items: StoryItemDetail[] | undefined) {
const currentContextTime = audioContext.currentTime;
const currentStoryTime = useStoryStore.getState().currentTimeMs;

console.log('[StoryPlayback] Setting timing anchors after seek:', {
contextTime: currentContextTime,
storyTime: currentStoryTime,
});
setPlaybackTiming(currentContextTime, currentStoryTime);

// Stop all existing sources and reschedule from new position
Expand Down
14 changes: 0 additions & 14 deletions app/src/stores/storyStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,20 +69,6 @@ export const useStoryStore = create<StoryPlaybackState>((set, get) => ({
const shouldResume = currentState.playbackStoryId === storyId && currentState.currentTimeMs > 0;
const startTimeMs = shouldResume ? currentState.currentTimeMs : minStartTimeMs;

console.log('[StoryStore] Play called:', {
storyId,
itemCount: items.length,
items: items.map((i) => ({
id: i.generation_id,
start: i.start_time_ms,
duration: i.duration,
})),
maxEndTimeMs,
minStartTimeMs,
startTimeMs,
shouldResume,
});

set({
isPlaying: true,
playbackStoryId: storyId,
Expand Down