Skip to content

Update .dockerignore#861

Open
shabeervpk wants to merge 1 commit into
jamiepine:mainfrom
shabeervpk:patch-1
Open

Update .dockerignore#861
shabeervpk wants to merge 1 commit into
jamiepine:mainfrom
shabeervpk:patch-1

Conversation

@shabeervpk

@shabeervpk shabeervpk commented Jul 8, 2026

Copy link
Copy Markdown

whitelist ROCm entrypoint

Summary by CodeRabbit

  • Bug Fixes
    • Updated packaging rules so most helper scripts are excluded from the build context, while the required entrypoint script remains included. This helps prevent missing runtime files and reduces unintended build contents.

whitelist ROCm entrypoint
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d63466cc-827c-4037-9cf1-139dcc1cf5f6

📥 Commits

Reviewing files that changed from the base of the PR and between f2cf2a7 and 1c65e16.

📒 Files selected for processing (1)
  • .dockerignore

📝 Walkthrough

Walkthrough

The .dockerignore file was updated to change the ignore rule for the scripts directory from a blanket exclusion to a wildcard exclusion with a specific negation, allowing scripts/rocm-entrypoint.sh to be included in the Docker build context.

Changes

Dockerignore Update

Layer / File(s) Summary
Update scripts ignore pattern
.dockerignore
Replaced blanket scripts/ ignore with scripts/* plus a negation rule re-including scripts/rocm-entrypoint.sh.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and correctly identifies the main change to .dockerignore.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant