fix rubocop complaints with sdam_prose_spec

Author: jamis

.github/workflows/rubocop.yml

@@ -1,7 +1,7 @@
 ---
 name: Rubocop
 
-on: [push, pull_request]
+on: [ push ]
 
 jobs:
   build:

spec/integration/sdam_prose_spec.rb

@@ -61,6 +61,7 @@
     end
   end
 
+  # rubocop:disable Naming/VariableName, RSpec/InstanceVariable
   describe 'Connection Pool Backpressure' do
     min_server_fcv '8.2'
     require_topology :single
@@ -72,8 +73,8 @@
         SpecConfig.instance.addresses,
         SpecConfig.instance.all_test_options.merge(
           max_connecting: 100,
-          max_pool_size: 100,
-        ),
+          max_pool_size: 100
+        )
       ).tap do |client|
         client.subscribe(Mongo::Monitoring::CONNECTION_POOL, subscriber)
       end
@@ -89,25 +90,25 @@
          defined?(@prev_ingressConnectionEstablishmentMaxQueueDepth)
         admin_db.command(
           setParameter: 1,
-          ingressConnectionEstablishmentRateLimiterEnabled: @prev_ingressConnectionEstablishmentRateLimiterEnabled,
+          ingressConnectionEstablishmentRateLimiterEnabled: @prev_ingressConnectionEstablishmentRateLimiterEnabled
         )
         admin_db.command(
           setParameter: 1,
-          ingressConnectionEstablishmentRatePerSec: @prev_ingressConnectionEstablishmentRatePerSec,
+          ingressConnectionEstablishmentRatePerSec: @prev_ingressConnectionEstablishmentRatePerSec
         )
         admin_db.command(
           setParameter: 1,
-          ingressConnectionEstablishmentBurstCapacitySecs: @prev_ingressConnectionEstablishmentBurstCapacitySecs,
+          ingressConnectionEstablishmentBurstCapacitySecs: @prev_ingressConnectionEstablishmentBurstCapacitySecs
         )
         admin_db.command(
           setParameter: 1,
-          ingressConnectionEstablishmentMaxQueueDepth: @prev_ingressConnectionEstablishmentMaxQueueDepth,
+          ingressConnectionEstablishmentMaxQueueDepth: @prev_ingressConnectionEstablishmentMaxQueueDepth
         )
       else
         # Fallback: at least disable the limiter if previous values were not captured.
         admin_db.command(
           setParameter: 1,
-          ingressConnectionEstablishmentRateLimiterEnabled: false,
+          ingressConnectionEstablishmentRateLimiterEnabled: false
         )
       end
     end
@@ -121,7 +122,7 @@
         ingressConnectionEstablishmentRateLimiterEnabled: 1,
         ingressConnectionEstablishmentRatePerSec: 1,
         ingressConnectionEstablishmentBurstCapacitySecs: 1,
-        ingressConnectionEstablishmentMaxQueueDepth: 1,
+        ingressConnectionEstablishmentMaxQueueDepth: 1
       ).first
 
       @prev_ingressConnectionEstablishmentRateLimiterEnabled =
@@ -136,35 +137,33 @@
       # Enable the ingress rate limiter with test-specific values.
       admin_db.command(
         setParameter: 1,
-        ingressConnectionEstablishmentRateLimiterEnabled: true,
+        ingressConnectionEstablishmentRateLimiterEnabled: true
       )
       admin_db.command(
         setParameter: 1,
-        ingressConnectionEstablishmentRatePerSec: 20,
+        ingressConnectionEstablishmentRatePerSec: 20
       )
       admin_db.command(
         setParameter: 1,
-        ingressConnectionEstablishmentBurstCapacitySecs: 1,
+        ingressConnectionEstablishmentBurstCapacitySecs: 1
       )
       admin_db.command(
         setParameter: 1,
-        ingressConnectionEstablishmentMaxQueueDepth: 1,
+        ingressConnectionEstablishmentMaxQueueDepth: 1
       )
 
       # Add a document so $where has something to process.
       client.use('test')['test'].delete_many
       client.use('test')['test'].insert_one({})
 
       # Run 100 parallel find_one operations that contend for connections.
-      threads = 100.times.map do
+      threads = Array.new(100) do
         Thread.new do
-          begin
-            client.use('test')['test'].find(
-              '$where' => 'function() { sleep(2000); return true; }'
-            ).first
-          rescue StandardError
-            # Ignore connection errors (including checkout timeouts).
-          end
+          client.use('test')['test'].find(
+            '$where' => 'function() { sleep(2000); return true; }'
+          ).first
+        rescue StandardError
+          # Ignore connection errors (including checkout timeouts).
         end
       end
       threads.each(&:join)
@@ -176,4 +175,5 @@
       expect(checkout_failed.length).to be >= 10
     end
   end
+  # rubocop:enable Naming/VariableName, RSpec/InstanceVariable
 end