Skip to content

Commit 17cc731

Browse files
authored
Merge pull request #3681 from softins/cpp17-resultof-deprecation
Fix deprecation of result_of in C++17
2 parents 903cd2e + 84670af commit 17cc731

1 file changed

Lines changed: 14 additions & 3 deletions

File tree

src/threadpool.h

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,24 @@
3535
#include <functional>
3636
#include <stdexcept>
3737

38+
// compatibility with C++17 deprecation of result_of
39+
#if __cplusplus >= 201703L
40+
// std::invoke_result_t should be used from C++17 onwards, but is not available in C++14 and earlier
41+
template<class F, class... Args>
42+
using threadpool_result_t = std::invoke_result_t<F, Args...>;
43+
#else
44+
// std::result_of should be used on C++14 and earlier, but is deprecated in C++17
45+
template<class F, class... Args>
46+
using threadpool_result_t = typename std::result_of<F ( Args... )>::type;
47+
#endif
48+
3849
class CThreadPool
3950
{
4051
public:
4152
CThreadPool() = default;
4253
CThreadPool ( size_t );
4354
template<class F, class... Args>
44-
auto enqueue ( F&& f, Args&&... args ) -> std::future<typename std::result_of<F ( Args... )>::type>;
55+
auto enqueue ( F&& f, Args&&... args ) -> std::future<threadpool_result_t<F, Args...>>;
4556
~CThreadPool();
4657

4758
private:
@@ -87,9 +98,9 @@ inline CThreadPool::CThreadPool ( size_t threads ) : stop ( false )
8798

8899
// add new work item to the pool
89100
template<class F, class... Args>
90-
auto CThreadPool::enqueue ( F&& f, Args&&... args ) -> std::future<typename std::result_of<F ( Args... )>::type>
101+
auto CThreadPool::enqueue ( F&& f, Args&&... args ) -> std::future<threadpool_result_t<F, Args...>>
91102
{
92-
using return_type = typename std::result_of<F ( Args... )>::type;
103+
using return_type = threadpool_result_t<F, Args...>;
93104

94105
auto task = std::make_shared<std::packaged_task<return_type()>> ( std::bind ( std::forward<F> ( f ), std::forward<Args> ( args )... ) );
95106

0 commit comments

Comments
 (0)