Want to submit a PR while another one is awaiting approval...

[digable1]

1. I have a PR, Add new JSON-RPC API calls, with documentation #3660 (comment), that has not yet been approved (generated a bunch of discussion) - related to new JSON-RPC API calls.

2. I have a new PR to submit.
   a. This is an extension of the current pending PR that adds more API calls, and actually copies the ones previously submitted.
   b. New API calls:
       1'. jamulusclient/connect
       2'. jamulusclient/disconnect
       3'. jamulusclient/setCurrentDirectory
   c. New attribute to jamulusclient/getChannelInfo: result.id // The channel ID assigned by the server, or -1 if not currently connected.
   d. This PR will need review attention - there's re-factoring in order to extract the common connect and disconnect logic used by both the UI and these new API calls. Note: Calling the API calls updates the UI (and states, such as the connect/disconnect buttons). This has been tested, but not to the extent I feel completely comfortable with (let's say there's a modicum of confidence). And I still get to play my newbie card.

3. Github will only let me own one fork of a repo - which is the one currently used for the pending PR.
   a. I could withdraw the current PR, freeing up my 1-fork allowance - but concerned about losing the valuable discussion that occurred as well as any review work that has been already done.
   b. I could create another temporary username/account, which opens up a fork slot (would rather not do that).
   c. I could wait for the PR to get approved, so my current fork is no longer needed, and I can overwrite with this new submission.

Btw: I took the comment of wanting the API to have parity with the UI to heart - which was the genesis of these new API calls in order to get a bit closer to that comment. This is certainly not all of the gaps (I have a list that Claude found, which is for a separate conversation).

How should I proceed?

[dingodoppelt]

Thanks for your efforts! Feel free to create a new PR from your newer changes. You can leave #3660 open, convert it to draft or close it. This won't make it disappear.

3. Github will only let me own one fork of a repo - which is the one currently used for the pending PR.
a. I could withdraw the current PR, freeing up my 1-fork allowance - but concerned about losing the valuable discussion that occurred as well as any review work that has been already done.
b. I could create another temporary username/account, which opens up a fork slot (would rather not do that ).
c. I could wait for the PR to get approved, so my current fork is no longer needed, and I can overwrite with this new submission.

You can fork Jamulus into your own repo and work on as many branches as you'd like to add. You can then create PRs from every branch you created. No limits ;)

My workflow is this:

1. Create a fork of Jamulus on github in your own repo
2. Clone this fork to your local machine and get to work on the code
3. Commit your changes to a new branch and push to your github fork
4. Create a PR to merge your branch from your fork into upstream Jamulus:main

[pljones]

I'm frequently working on multiple parallel and sequential PRs -- i.e. some independent changes and some that require earlier changes. All in the one forked tree.

For sequential, something like this:
git checkout -b step-1
git commit -m 'first bit ... however many commits'
git push -u ; # raise the PR for step-1
git checkout -b step-2 ;# based of HEAD of step-1, any rework, switch back, do the changes, rebase step-2

For parallel, obviously, checkout main and then a fresh branch.

Always git pull upstream main && git push when you switch to main, then keep all your branches rebased appropriately.

(I don't agree with merging from parent branches - it creates unnecessary noise. Rebase is better.)

[ann0see]

jamulusclient/connect and disconnect please put this in a separate PR. It is quite hard to get correct as the GUI must remain in sync. Last time someone tried it it wasn't approvable as the UI went out of sync.

It's still a very important feature.