Fix memory leak found by copilot

[ann0see]

Short description of changes

Tries to fix memory leak found by copilot: See: #3702 This should be valiated. I checked that the audio alerts still play - and it seems to work, but further investigation is still needed. I experienced hearing an audio-alert twice - but that may just be due to my testing mythology.

CHANGELOG: Bugfix: Fix memory leak for audio alerts

Context: Fixes an issue?

See: #3702

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Needs review and testing.

What is missing until this pull request can be merged?

Testing

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[softins]

This looks good. I've built and tried it, and verified by adding debug messages that the deleteLater() is being called when it should be in each case.

[pljones]

I think I'd feel happier with this duplicated code factored out into a method. That way any future sound effects can be played by the same code, without having to write another copy.

[ann0see]

Weird. It compiled for me locally.

[softins]

Weird. It compiled for me locally.

I think it might be better to put PlayAudioAlert() in clientdlg instead of moving it to util.

[softins]

Weird. It compiled for me locally.

I think it might be better to put PlayAudioAlert() in clientdlg instead of moving it to util.

Yes, you definitely should, as it is specific to the client GUI.

The Linux build in CI builds both a GUI and a headless version, and it is the headless one that is failing, because the include paths for QtWidgets, QtMultimedia and QtGUI are not in the headless build.

If you want to keep PlayAudioAlert() in util, you need to put the #include <QSoundEffect> within the #ifndef HEADLESS section with the other GUI includes, and also protect the declaration and definition of PlayAudioAlert() with #ifndef HEADLESS too. I think it's easier and more logical just to move it back to clientdlg.

[softins]

I suppose if you might want to use it in serverdlg too, you could keep it in util, and just do the #ifndef thing.

[softins]

I just pushed a commit to try it.

[ann0see]

Thanks. The idea was that one could use audio alerts everywhere. So util.* seemed the best fitting location.

[pljones]

Weird. It compiled for me locally.

I think it might be better to put PlayAudioAlert() in clientdlg instead of moving it to util.

Not in the graphical UI, if it's avoidable. I'd rather we had the assistive UI support separately, so it could be used even if the graphical UI was not in used. There's too much functional code there.

[softins]

Not in the graphical UI, if it's avoidable. I'd rather we had the assistive UI support separately, so it could be used even if the graphical UI was not in used. There's too much functional code there.

It's ok, we've left it in util.*, but excluded for headless compilation, as QSoundEffect is a GUI-only module in Qt anyway.

I think this is ready to go in now.