Refactor server chat handling by extracting methods#3741
Merged
Conversation
Merged
5 tasks
…k method to MathUtils
80a5147 to
562d6c6
Compare
Merged
5 tasks
ann0see
reviewed
Jun 17, 2026
pljones
reviewed
Jun 18, 2026
pljones
reviewed
Jun 18, 2026
pljones
reviewed
Jun 18, 2026
Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
pljones
approved these changes
Jun 20, 2026
ann0see
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
This refactors
CServer::CreateAndSendChatTextForAllConChannelsinto three functions for sending messages.The extracted methods
As it is now possible to call the function to send a message to a channel directly, the channel number needs to be boundary checked.
A function
InRange()was introduced intoutil.hfor that purpose.CHANGELOG: Refactor server chat handling by extracting methods
Context: Fixes an issue?
Not yet ;)
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Review, Approval
Checklist