Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Commit 5eea345

Browse files
committed
remove old tests. some chores
1 parent 5feda51 commit 5eea345

6 files changed

Lines changed: 2 additions & 37 deletions

File tree

engine/e2e-test/api/engines/test_api_engine.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,16 +52,6 @@ async def test_engines_install_uninstall_llamacpp_should_be_successful(self):
5252
response = requests.delete("http://localhost:3928/v1/engines/llama-cpp/install")
5353
assert response.status_code == 200
5454

55-
@pytest.mark.asyncio
56-
async def test_engines_install_uninstall_python_should_be_successful(self):
57-
response = requests.post("http://localhost:3928/v1/engines/python-engine/install")
58-
assert response.status_code == 200
59-
await wait_for_websocket_download_success_event(timeout=None)
60-
time.sleep(30)
61-
62-
response = requests.delete("http://localhost:3928/v1/engines/python-engine/install")
63-
assert response.status_code == 200
64-
6555
@pytest.mark.asyncio
6656
async def test_engines_install_uninstall_llamacpp_with_only_version_should_be_failed(self):
6757
# install first

engine/e2e-test/api/engines/test_api_engine_install_nightly.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ def test_engines_install_llamacpp_should_be_successful(self):
2222
response = requests.post("http://localhost:3928/v1/engines/llama-cpp/install")
2323
assert response.status_code == 200
2424

25-
def test_engines_install_python_should_be_successful(self):
26-
response = requests.post("http://localhost:3928/v1/engines/python-engine/install")
27-
assert response.status_code == 200
28-
2925
def test_engines_install_llamacpp_specific_version_and_variant(self):
3026
data = {"version": latest_pre_release_tag, "variant": "linux-amd64-avx"}
3127
response = requests.post(

engine/e2e-test/cli/engines/test_cli_engine_install.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,6 @@ def test_engines_install_llamacpp_should_be_successfully(self):
3131
assert len(response.json()) > 0
3232
assert exit_code == 0, f"Install engine failed with error: {error}"
3333

34-
def test_engines_install_python_should_be_successfully(self):
35-
exit_code, output, error = run(
36-
"Install Engine",
37-
["engines", "install", "python-engine"],
38-
timeout=None,
39-
capture=False,
40-
)
41-
response = requests.get("http://127.0.0.1:3928/v1/engines/python-engine")
42-
assert len(response.json()) > 0
43-
assert exit_code == 0, f"Install engine failed with error: {error}"
44-
4534
@pytest.mark.skipif(reason="Ignore onnx-runtime test")
4635
def test_engines_install_onnx_on_macos_should_be_failed(self):
4736
exit_code, output, error = run(

engine/e2e-test/cli/engines/test_cli_engine_install_nightly.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,6 @@ def test_engines_install_llamacpp_should_be_successfully(self):
3131
assert len(response.json()) > 0
3232
assert exit_code == 0, f"Install engine failed with error: {error}"
3333

34-
def test_engines_install_python_should_be_successfully(self):
35-
exit_code, output, error = run(
36-
"Install Engine",
37-
["engines", "install", "python-engine"],
38-
timeout=None,
39-
capture=False,
40-
)
41-
response = requests.get("http://127.0.0.1:3928/v1/engines/python-engine")
42-
assert len(response.json()) > 0
43-
assert exit_code == 0, f"Install engine failed with error: {error}"
44-
4534
@pytest.mark.skipif(reason="Ignore onnx-runtime test")
4635
def test_engines_install_onnx_on_macos_should_be_failed(self):
4736
exit_code, output, error = run(

engine/extensions/python-engines/python_utils.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ cpp::result<void, std::string> UvInstall() {
3939
std::filesystem::create_directories(py_bin_path);
4040

4141
// NOTE: do we need a mechanism to update uv, or just pin uv version with cortex release?
42-
const std::string uv_version = "0.6.3";
42+
const std::string uv_version = "0.6.11";
4343

4444
// build download url based on system info
4545
std::stringstream fname_stream;

engine/extensions/python-engines/vllm_engine.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ std::vector<EngineVariantResponse> VllmEngine::GetVariants() {
8181
std::vector<EngineVariantResponse> variants;
8282
for (const auto& entry : fs::directory_iterator(vllm_path)) {
8383
const auto name = "linux-amd64-cuda"; // arbitrary
84+
// TODO: after llama-server is merged, check if we need to add "v"
8485
const auto version_str = "v" + entry.path().filename().string();
8586
const EngineVariantResponse variant{name, version_str, kVllmEngine};
8687
variants.push_back(variant);

0 commit comments

Comments
 (0)