Skip to content

Commit 048a490

Browse files
juliendenizeCISC
andauthored
convert : Mistral format yarn apply_scale support (ggml-org#22612)
* [BUGFIX] Mistral format apply_scale support. * Update convert_hf_to_gguf.py Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> * fix misunderstood boolean parameters --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
1 parent db44417 commit 048a490

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

convert_hf_to_gguf.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12716,11 +12716,12 @@ def set_gguf_parameters(self):
1271612716
def set_mistral_config(gguf_writer: gguf.GGUFWriter, hparams: dict):
1271712717
if "yarn" in hparams:
1271812718
yarn_params = hparams["yarn"]
12719+
mscale_all_dim = 1.0 if not yarn_params["apply_scale"] else 0.0
1271912720
gguf_writer.add_rope_scaling_type(gguf.RopeScalingType.YARN)
1272012721
gguf_writer.add_rope_scaling_factor(yarn_params["factor"])
1272112722
gguf_writer.add_rope_scaling_yarn_beta_fast(yarn_params["beta"])
1272212723
gguf_writer.add_rope_scaling_yarn_beta_slow(yarn_params["alpha"])
12723-
gguf_writer.add_rope_scaling_yarn_log_mul(1.0) # mscale_all_dim
12724+
gguf_writer.add_rope_scaling_yarn_log_mul(mscale_all_dim)
1272412725
gguf_writer.add_rope_scaling_orig_ctx_len(yarn_params["original_max_position_embeddings"])
1272512726

1272612727
if "llama_4_scaling" in hparams:

src/llama-model.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1994,7 +1994,7 @@ void llama_model::load_hparams(llama_model_loader & ml) {
19941994
}
19951995
}
19961996

1997-
if (ml.get_key(LLM_KV_ROPE_SCALING_YARN_LOG_MUL, hparams.rope_yarn_log_mul, 0.0f)) {
1997+
if (ml.get_key(LLM_KV_ROPE_SCALING_YARN_LOG_MUL, hparams.rope_yarn_log_mul, false)) {
19981998
// [TAG_DEEPSEEK2_YARN_LOG_MUL_FIX]
19991999
// cancel the factor from the convert script
20002000
hparams.rope_yarn_log_mul /= 0.1f;
@@ -2868,7 +2868,7 @@ void llama_model::load_hparams(llama_model_loader & ml) {
28682868

28692869
ml.get_key(LLM_KV_ROPE_SCALING_YARN_BETA_FAST, hparams.yarn_beta_fast, false);
28702870
ml.get_key(LLM_KV_ROPE_SCALING_YARN_BETA_SLOW, hparams.yarn_beta_slow, false);
2871-
ml.get_key(LLM_KV_ROPE_SCALING_YARN_LOG_MUL, hparams.rope_yarn_log_mul, 0.0f);
2871+
ml.get_key(LLM_KV_ROPE_SCALING_YARN_LOG_MUL, hparams.rope_yarn_log_mul, false);
28722872

28732873
hparams.f_attn_temp_offset = 0.0f;
28742874

0 commit comments

Comments
 (0)