feature: C++ Direct Call Support#727
Draft
stmonty wants to merge 31 commits into
Draft
Conversation
# Conflicts: # compiler+runtime/src/cpp/jank/codegen/processor.cpp
# Conflicts: # compiler+runtime/src/cpp/jank/codegen/processor.cpp
Member
|
Hey Monty! Glad to see a PR coming through for this. On first glance, this approach looks pretty much like the old approach. It's not using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds C++ codegen direct-call support. Right now I am still following similar to the LLVM codegen where we cache a var-root. This is pretty similar to the older PR, just modified for the current codegen strategy.
However, I am still working on making this match more closely to the JVM Clojure codegen, where it emits direct static calls to the var's function.
Just some current numbers. The simple benchmark is benchmarking mostly derefs:
Note: AI was used for general conversation, debugging and some code clean-up and comment clarity.