Skip to content

Add async, upgrade app packages#23

Open
mikkelking wants to merge 5 commits into
jankapunkt:masterfrom
mikkelking:expo-upgrade
Open

Add async, upgrade app packages#23
mikkelking wants to merge 5 commits into
jankapunkt:masterfrom
mikkelking:expo-upgrade

Conversation

@mikkelking

Copy link
Copy Markdown

Summary

  • Upgrade app packages to make it work again
  • Made database calls async, ready for v3

Linked issue(s)

#22

Involved parts of the project

  • app
  • backend

Reproduction

Just run it up

@jankapunkt jankapunkt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mikkelking good to see you here, been a long time! Thanks a lot for the update, I got a few comments we should discuss before continuing. Once they are resolved we can move forward.

Comment thread app/package.json Outdated
Comment thread app/package.json Outdated
Comment thread app/package.json Outdated
Comment thread backend/imports/tasks/methods.js Outdated
Comment thread backend/imports/tasks/methods.js Outdated
Comment thread backend/imports/tasks/methods.js Outdated
Comment thread app/package.json
Comment thread app/package.json
@mikkelking

Copy link
Copy Markdown
Author

@jankapunkt I made changes to remove unnecessary packages. I locked some react-native versions to prevent expo warnings, but this could be short sighted ?

@jankapunkt

Copy link
Copy Markdown
Owner

@mikkelking would you mind to check the failing tests? The backend lint issues should be fixable using meteor npm run lint:fix and for the tests please make sure your changes did not break existing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants