Skip to content

Commit 2968414

Browse files
authored
cacheable-request - chore: upgrading sqlite3 to latest (#1634)
* cacheable-request - chore: upgrading sqlite3 to latest * Update cacheable-request-instance.test.ts
1 parent 752eeff commit 2968414

7 files changed

Lines changed: 347 additions & 186 deletions

File tree

.github/workflows/codecov.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
node-version: ${{ matrix.node-version }}
2727

2828
- name: Install pnpm
29-
run: npm install -g pnpm
29+
run: npm install -g pnpm@10
3030

3131
- name: Start Test Services
3232
run: pnpm test:services:start

.github/workflows/deploy-website.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
node-version: 24
2525

2626
- name: Install PNPM
27-
run: npm install -g pnpm
27+
run: npm install -g pnpm@10
2828

2929
- name: Install Modules
3030
run: pnpm install

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
node-version: ${{ matrix.node-version }}
2727

2828
- name: Install pnpm
29-
run: npm install -g pnpm
29+
run: npm install -g pnpm@10
3030

3131
- name: Start Test Services
3232
run: pnpm test:services:start

packages/benchmark/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
"license"
6363
],
6464
"devDependencies": {
65-
"@cacheable/node-cache": "^1.5.6",
65+
"@cacheable/node-cache": "workspace:^",
6666
"node-cache": "^5.1.2",
6767
"tsx": "^4.21.0"
6868
}

packages/cacheable-request/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"delay": "^7.0.0",
6060
"express": "^5.2.1",
6161
"pify": "^6.1.0",
62-
"sqlite3": "^5.1.7",
62+
"sqlite3": "^6.0.1",
6363
"tsup": "^8.5.1",
6464
"typescript": "^5.9.3"
6565
}

packages/cacheable-request/test/cacheable-request-instance.test.ts

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { request } from "node:http";
44
import stream from "node:stream";
55
import { KeyvSqlite } from "@keyv/sqlite";
66
import getStream from "get-stream";
7+
import { Keyv } from "keyv";
78
import { afterAll, beforeAll, expect, test } from "vitest";
89
import CacheableRequest, { parseWithWhatwg } from "../src/index.js";
910
import { CacheError, RequestError } from "../src/types.js";
@@ -366,3 +367,26 @@ test("cacheableRequest emits CacheError if request cancels", () => {
366367
})
367368
.on("request", (request_: any) => request_.abort());
368369
});
370+
371+
test("cacheableRequest emits CacheError when underlying Keyv emits error event", async () => {
372+
const keyv = new Keyv();
373+
keyv.get = () => new Promise(() => {});
374+
const errorMessage = "synthetic keyv error";
375+
const cacheableRequest = new CacheableRequest(request, keyv).request();
376+
377+
await new Promise<void>((resolve, reject) => {
378+
cacheableRequest(parseWithWhatwg(s.url)).on("error", (error: any) => {
379+
try {
380+
expect(error instanceof CacheError).toBeTruthy();
381+
expect(error.message).toBe(errorMessage);
382+
resolve();
383+
} catch (assertionError) {
384+
reject(assertionError);
385+
}
386+
});
387+
388+
setImmediate(() => {
389+
keyv.emit("error", new Error(errorMessage));
390+
});
391+
});
392+
});

0 commit comments

Comments
 (0)