Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"docker:readme": "tsx ./scripts/create-docker-readme.ts",
"docker:compose:up": "docker-compose up -d",
"docker:compose:down": "docker-compose down",
"prepare": "pnpm run build",
"prepublishOnly": "pnpm run build",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Changing the prepare script to prepublishOnly is a regression in the build workflow. The prepare script ensures that the project is built automatically after a local pnpm install, which is necessary for the start script (node dist/index.js) to work correctly on a fresh clone. With prepublishOnly, developers will have to manually run pnpm build after installation. It is recommended to keep this as prepare to maintain a smooth developer experience.

Suggested change
"prepublishOnly": "pnpm run build",
"prepare": "pnpm run build",

"start": "node dist/index.js"
},
"repository": {
Expand Down Expand Up @@ -51,15 +51,15 @@
},
"homepage": "https://github.com/jaredwray/mockhttp#readme",
"devDependencies": {
"@biomejs/biome": "^2.4.7",
"@swc/core": "^1.15.18",
"@biomejs/biome": "^2.4.11",
"@swc/core": "^1.15.24",
"@types/html-escaper": "^3.0.4",
"@vitest/coverage-v8": "^4.1.0",
"@vitest/coverage-v8": "^4.1.4",
"rimraf": "^6.1.3",
"tsup": "^8.5.1",
"tsx": "^4.21.0",
"typescript": "^5.9.3",
"vitest": "^4.1.0"
"vitest": "^4.1.4"
},
"dependencies": {
"@fastify/cookie": "^11.0.2",
Expand Down
Loading
Loading