Make pgmq_all_variants fixture async driver aware#41
Merged
jason810496 merged 3 commits intoJan 6, 2026
Merged
Conversation
…ync fixtures only Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com>
Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add CST-based script to complete missing async methods
Make pgmq_all_variants fixture async driver aware
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
pgmq_all_variantsfixture was parametrizing tests with both sync and async driver variants, causing failures when dependent fixtures (pgmq_setup_teardown,pgmq_partitioned_setup_teardown) called methods likecreate_queue()anddrop_queue()withoutawaiton async PGMQ instances.Changes
pytest_generate_teststo exclude async fixtures frompgmq_all_variantsparametrization. Tests using this fixture now skip when--driver=asyncpgis specified.pgmq_all_variantsonly provides sync driver variants. Async tests should use async fixtures directly (pgmq_by_async_dsn,pgmq_by_async_engine,pgmq_by_async_session_maker).Behavior
--driver=psycopg2): Only sync fixtures used--driver=asyncpg): Tests usingpgmq_all_variantsare skippedAsync tests in
test_operation.pyalready use async fixtures directly and are unaffected.Status
Checklist
pre-commitwithruff)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.