Skip to content

Not handling reginal characters like å,ä,ö #2

Description

@Zeith78

I've noticed that downloading files that has umlauts or other similar non-standard english charaters results in a 404.
It will also give a 404 if it tries to download a file that has a # somewhere in its name.

Changing in MainWindow.xaml.cs (259):

try
{
   client.DownloadFile($"https://archive.org/download/{collectionName}/{file.Name}", destinationFilePath);
}

to:

try
{
   var fixed_filename = System.Uri.EscapeDataString(file.Name).ToString();
   client.DownloadFile($"https://archive.org/download/{collectionName}/{fixed_filename}", destinationFilePath);
}

fixes this problem. Its not the prettiest code, but it works.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions