Skip to content

Commit f2c26d7

Browse files
authored
Merge pull request #53 from javecs/feature/reformat
コードを整理しました。
2 parents d1c3a27 + 3969ce2 commit f2c26d7

3 files changed

Lines changed: 13 additions & 25 deletions

File tree

src/main/kotlin/xyz/javecs/tools/text2expr/Text2Expr.kt

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,20 +22,15 @@ class Text2Expr(rulePath: String = "rules") {
2222
.filterNot { it.value == Double.NaN }
2323
.sortedByDescending { it.coverage }
2424
.toList()
25-
return if (evaluated.isEmpty()) {
26-
Calculator().eval(normalize(text)).value.toString()
27-
} else {
25+
return if (evaluated.isNotEmpty()) {
2826
val bestMatch = evaluated.first()
29-
if (rendered) {
30-
RuleRenderer(templates.templateOf(bestMatch.rule)).apply {
31-
add("variables", bestMatch.variables.map { Variable(it.key, it.value) }.toList())
32-
add("expr", bestMatch.expr)
33-
add("text", text)
34-
add("value", bestMatch.value)
35-
}.render()
36-
} else {
37-
bestMatch.value.toString()
38-
}
39-
}
27+
if (rendered) RuleRenderer(templates.templateOf(bestMatch.rule)).apply {
28+
add("variables", bestMatch.variables.map { Variable(it.key, it.value) }.toList())
29+
add("expr", bestMatch.expr)
30+
add("text", text)
31+
add("value", bestMatch.value)
32+
}.render()
33+
else bestMatch.value.toString()
34+
} else Calculator().eval(normalize(text)).value.toString()
4035
}
4136
}

src/main/kotlin/xyz/javecs/tools/text2expr/rules/RuleBuilder.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,6 @@ class RuleBuilder(source: String, val name: String = "") {
7575
args.forEach { calc.eval(it) }
7676
expr().forEach { calc.eval(it) }
7777
Evaluation(calc.value, expr().toList(), calc.variables(), coverage, name)
78-
} else {
79-
Evaluation(rule = name)
80-
}
78+
} else Evaluation(rule = name)
8179
}
82-
8380
}

src/main/kotlin/xyz/javecs/tools/text2expr/templates/TemplateLoader.kt

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,15 @@ package xyz.javecs.tools.text2expr.templates
33
import org.yaml.snakeyaml.Yaml
44
import xyz.javecs.tools.text2expr.utils.read
55

6+
private val printValue = "<if(value)><value><endif>"
7+
68
data class Templates(var templates: List<RuleTemplate> = ArrayList<RuleTemplate>())
79
data class RuleTemplate(var rule: String = "", var template: String = "")
810

9-
private val printValue = "<if(value)><value><endif>"
10-
1111
class TemplateLoader(path: String = "rule-template.yml", val defaultTemplate: String = printValue) {
1212
private val config = Yaml().loadAs(read(path), Templates::class.java)
1313
fun templateOf(rule: String): String {
1414
val item = config.templates.find { it.rule == rule }
15-
return if (item == null) {
16-
defaultTemplate
17-
} else {
18-
read(item.template)
19-
}
15+
return if (item == null) defaultTemplate else read(item.template)
2016
}
2117
}

0 commit comments

Comments
 (0)