Comments on Makefile

[ilario]

Thanks for packaging this!
Much much more convenient than compiling manually!

Here some observations on the Makefile:

PKG_SOURCE_URL is specified twice.

In the define Package/vwifi/postinst there is some text. I would suggest to write also in English so that it is more likely that this package gets accepted in the OpenWrt repositories at some point :)

The package indicates version 1.0.0 but vwifi is at version 7. Maybe the Makefile should be linked to a specific version of vwifi or use the same version number? I don't know what is OpenWrt's tradition on this... Another option: if it is always pointing to the latest version, it could indicate this in the package name. For example, it could be named vwifi-client-git.

I got this warning:
WARNING: No feed for source package 'cmake' found
and
WARNING: Makefile 'package/feeds/vwifi/vwifi/Makefile' has a build dependency on 'cmake/host', which does not exist
when compiling on OpenWrt 24. cmake is a dependency for the building computer, not for the router, right? This warning seems to indicate that the buildroot is looking for cmake, but it is not up to the buildroot to install it. It could be included in the list here https://openwrt.org/docs/guide-developer/toolchain/install-buildsystem#prerequisites but it is not as it is already included in OpenWrt's tools directory. Maybe it should be specified in some other way or it is not needed at all?

Similarly to the previous point: libnl is needed just at compile time or also inside the router?
Right now, the Makefile selects libnl for installation in the router.

[ilario]

I tried to compile and got this error, caused by the patch:

build_dir/target-mipsel_24kc_musl/vwifi-1.0.0/src/cmonwirelessdevice.cc:210:94: error: too many initializers for 'msghdr'
  210 |         struct msghdr msg = { static_cast<void *>(&snl), sizeof(snl), &iov, 1, 0, 0, 0, 0, 0 };

It seems wrong in the vwifi wiki actually... https://github.com/Raizo62/vwifi/wiki/Install-on-OpenWRT-X86_64#download-the-code-of-vwifi

[ilario]

After changing the patch so that the number of zeros matches the original line's argument, it compiles.

[ilario]

The support for this has been merged here VGDSpehar/libremesh-virtual-mesh#2

Please consider pushing this package to OpenWrt as soon as you are happy with it.

[ilario]

Updates:

PKG_SOURCE_URL is specified twice.

Has been fixed.

In the define Package/vwifi/postinst there is some text. I would suggest to write also in English so that it is more likely that this package gets accepted in the OpenWrt repositories at some point :)

Most Spanish text has been replaced, thanks.
There is still some here:

vwifi_cli_package/package/vwifi/Makefile

Line 66 in 793ba1e

# Configurar módulo mac80211_hwsim con 0 radios por defecto

I got this warning: WARNING: No feed for source package 'cmake' found and WARNING: Makefile 'package/feeds/vwifi/vwifi/Makefile' has a build dependency on 'cmake/host', which does not exist when compiling on OpenWrt 24. cmake is a dependency for the building computer, not for the router, right? This warning seems to indicate that the buildroot is looking for cmake, but it is not up to the buildroot to install it. It could be included in the list here https://openwrt.org/docs/guide-developer/toolchain/install-buildsystem#prerequisites but it is not as it is already included in OpenWrt's tools directory. Maybe it should be specified in some other way or it is not needed at all?

This warning still happens, cmake/host dependency should be removed from the Makefile.

Similarly to the previous point: libnl is needed just at compile time or also inside the router? Right now, the Makefile selects libnl for installation in the router.

About this I still have no idea.

[javierbrk]

I left libnl since it is it's linked dynamically (shared library), not statically.