fix: terminal lifecycle and history viewer bugs

- History viewer read a session-id log that never exists; read per-pane logs (splitRoot.allPaneIds) and concatenate them
- Reset reveal counter on warm-terminal claim so it no longer flashes the previous $HOME prompt before its own cd && clear
- Verify warm terminal process is alive before handoff; dead PTY falls back to a cold spawn
- Implement processTerminated: clear exited terminals and reset status so the tab/notch no longer freeze on a dead shell
- Strip C1 control chars (U+0080-U+009F) from notification text
- Surface checkpoint-restore failures instead of swallowing with try?
- Measure real working duration for the taskCompleted filter
- Sparkle appcast advertises minimum macOS 26.0 (was 14.0)
- Remove dead code; de-duplicate buffer-read and launch-command paths

Author: javierpr0

CHANGELOG.md

@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.23.2] - 2026-05-29
+
+### Security
+- Notification text now strips C1 control characters (U+0080–U+009F, including NEL and CSI) in addition to C0/DEL, closing a notification-spoofing vector from hostile terminal output.
+
+### Fixed
+- Session history viewer always showed "No history". History is written per pane, but the viewer read a log keyed by the session id (a file that never exists). It now reads and concatenates every pane's log in the session's split tree.
+- Claimed warm-pool terminals briefly flashed the previous shell's `$HOME` prompt because the reveal counter wasn't reset. A claimed terminal now stays hidden until its own `cd && clear` completes.
+- A warm terminal whose shell had already exited could be handed to a new tab. The pool now verifies the process is alive before handoff and falls back to a fresh spawn.
+- A terminal whose shell exited (`exit`, crash, failing login script) left the tab/notch showing a frozen status and leaked the dead terminal. `processTerminated` now clears it and resets status (a later reselect respawns a fresh shell).
+- Restoring a checkpoint no longer fails silently — the error is logged instead of being swallowed by `try?`.
+- "Task completed" notifications were suppressed for many real tasks: the trivial-task filter measured wall time including the 3-second confirmation delay. It now measures actual working duration.
+
+### Changed
+- Sparkle appcast now advertises the correct minimum macOS (26.0). It previously defaulted to 14.0, offering the update to systems that cannot run the app.
+- Internal cleanup: removed dead code and de-duplicated the terminal buffer-reading and launch-command paths (no behavior change).
+
 ## [0.23.1] - 2026-05-28
 
 ### Changed
@@ -229,7 +246,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Global backtick hotkey to toggle panel
 - Pin panel open option
 
-[Unreleased]: https://github.com/javierpr0/notchly/compare/v0.23.1...HEAD
+[Unreleased]: https://github.com/javierpr0/notchly/compare/v0.23.2...HEAD
+[0.23.2]: https://github.com/javierpr0/notchly/compare/v0.23.1...v0.23.2
 [0.23.1]: https://github.com/javierpr0/notchly/compare/v0.23.0...v0.23.1
 [0.23.0]: https://github.com/javierpr0/notchly/compare/v0.22.5...v0.23.0
 [0.20.0]: https://github.com/javierpr0/notchly/compare/v0.19.0...v0.20.0

CLAUDE.md

@@ -18,7 +18,7 @@ Notchly is a macOS menu bar app that provides a floating terminal panel anchored
 
 ## Architecture
 
-**App lifecycle**: `NotchyApp` (in `BotdockApp.swift`) uses `@NSApplicationDelegateAdaptor` to delegate to `AppDelegate`, which owns the `NSStatusItem` (menu bar icon), the `TerminalPanel`, and the `NotchWindow`. The SwiftUI `App` body is an empty `Settings` scene — all UI lives in the panel and notch window.
+**App lifecycle**: `NotchyApp` (in `NotchyApp.swift`) uses `@NSApplicationDelegateAdaptor` to delegate to `AppDelegate`, which owns the `NSStatusItem` (menu bar icon), the `TerminalPanel`, and the `NotchWindow`. The SwiftUI `App` body is an empty `Settings` scene — all UI lives in the panel and notch window.
 
 **Notch integration**: `NotchWindow` is an always-visible `NSPanel` positioned over the MacBook notch. It detects notch dimensions via `NSScreen.auxiliaryTopLeftArea`/`auxiliaryTopRightArea`, tracks mouse hover to trigger the main panel, and expands with a bounce animation (via `CVDisplayLinkWrapper`) when any session is working. `NotchPillContent` (SwiftUI) renders status icons (spinner, checkmark, warning) inside the pill. `NotchDisplayState` computes a priority-based aggregate status across all sessions.
 
@@ -46,7 +46,7 @@ Notchly is a macOS menu bar app that provides a floating terminal panel anchored
 
 | File | Purpose |
 |------|---------|
-| `BotdockApp.swift` | App entry point (`NotchyApp`) |
+| `NotchyApp.swift` | App entry point (`NotchyApp`) |
 | `AppDelegate.swift` | Menu bar icon, hotkey, hover tracking, panel lifecycle |
 | `TerminalManager.swift` | Terminal creation, `ClickThroughTerminalView`, status detection, autocomplete integration |
 | `TerminalPanel.swift` | Floating panel window, keyboard shortcuts |
@@ -70,4 +70,4 @@ Notchly is a macOS menu bar app that provides a floating terminal panel anchored
 
 ## Entitlements
 
-The app requires `com.apple.security.automation.apple-events` for AppleScript communication with Xcode.
+`Notchy.entitlements` is currently empty (`<dict/>`) — the app is unsandboxed (required: it spawns the user's login shell and runs arbitrary commands) and declares no special entitlements. There is no AppleScript/Xcode-automation code. If Developer-ID signing + notarization is added later, any needed entitlement must be declared explicitly here, since CI currently signs ad-hoc (`CODE_SIGN_IDENTITY="-"`) and the hardened runtime isn't truly enforced.

Notchy/HistoryViewerPanel.swift

@@ -4,7 +4,7 @@ class HistoryViewerPanel: NSPanel {
     private let scrollView: NSScrollView
     private let textView: NSTextView
 
-    init(sessionName: String, sessionId: UUID) {
+    init(sessionName: String, paneIds: [UUID]) {
         scrollView = NSScrollView(frame: NSRect(x: 0, y: 0, width: 700, height: 500))
         scrollView.hasVerticalScroller = true
         scrollView.hasHorizontalScroller = false
@@ -42,7 +42,7 @@ class HistoryViewerPanel: NSPanel {
 
         // The read + ANSI strip runs off-main; fill the view when it lands so
         // opening history on a large log never blocks the UI.
-        SessionHistoryManager.shared.readHistoryAsync(for: sessionId) { [weak self] content in
+        SessionHistoryManager.shared.readHistoryAsync(for: paneIds) { [weak self] content in
             guard let self else { return }
             if content.isEmpty {
                 self.textView.string = L10n.shared.noHistory

Notchy/NotchWindow.swift

@@ -655,19 +655,6 @@ struct NotchPillContent: View {
     }
 }
 
-struct SpinnerView: View {
-    @State private var isAnimating = false
-
-    var body: some View {
-        Circle()
-            .trim(from: 0.05, to: 0.8)
-            .stroke(Color.white, style: StrokeStyle(lineWidth: 2, lineCap: .round))
-            .rotationEffect(.degrees(isAnimating ? 360 : 0))
-            .animation(.linear(duration: 0.8).repeatForever(autoreverses: false), value: isAnimating)
-            .onAppear { isAnimating = true }
-    }
-}
-
 // MARK: - CVDisplayLink wrapper for smooth animation
 
 /// Drives a frame-by-frame animation callback on the display refresh rate.

Notchy/SessionHistoryManager.swift

@@ -106,14 +106,24 @@ class SessionHistoryManager {
     /// only the final delivery hops back to main. Avoids a multi-hundred-ms
     /// main-thread stall when opening the history viewer on a large log.
     func readHistoryAsync(for sessionId: UUID, completion: @escaping (String) -> Void) {
-        let path = logPath(for: sessionId)
+        readHistoryAsync(for: [sessionId], completion: completion)
+    }
+
+    /// Reads and concatenates the logs of several panes (a session's split
+    /// tree) in tree order, each separated by a divider. All file work runs on
+    /// `queue`; only delivery hops to main.
+    func readHistoryAsync(for paneIds: [UUID], completion: @escaping (String) -> Void) {
         queue.async { [self] in
-            // Flush any buffered writes so reads see the latest data.
-            flushPending(for: sessionId)
-            openHandles[sessionId]?.synchronizeFile()
-            let raw = (try? String(contentsOf: path, encoding: .utf8)) ?? ""
-            let stripped = Self.stripAnsi(raw)
-            DispatchQueue.main.async { completion(stripped) }
+            var parts: [String] = []
+            for paneId in paneIds {
+                flushPending(for: paneId)
+                openHandles[paneId]?.synchronizeFile()
+                let raw = (try? String(contentsOf: logPath(for: paneId), encoding: .utf8)) ?? ""
+                let stripped = Self.stripAnsi(raw)
+                if !stripped.isEmpty { parts.append(stripped) }
+            }
+            let joined = parts.joined(separator: "\n\u{2500}\u{2500}\u{2500}\u{2500}\u{2500}\u{2500}\u{2500}\u{2500}\n")
+            DispatchQueue.main.async { completion(joined) }
         }
     }
 

Notchy/SessionStore.swift

@@ -76,6 +76,9 @@ class SessionStore {
         }
     }
 
+    /// Tasks whose working phase was shorter than this don't emit a
+    /// "task completed" pill/notification — avoids noise from trivial commands.
+    private static let minTaskWorkDuration: TimeInterval = 7
     private static let sessionsKey = "persistedSessions"
     private static let activeSessionKey = "activeSessionId"
     private static let persistDebounceInterval: TimeInterval = 1.5
@@ -324,16 +327,17 @@ class SessionStore {
             NotificationCenter.default.post(name: .NotchyNotchStatusChanged, object: nil)
         }
 
-        // Per-pane working→idle delay for taskCompleted
+        // Per-pane working→idle delay for taskCompleted. Skip trivial tasks,
+        // but measure the ACTUAL working duration (idle moment − start) now —
+        // the old check read `now − start` inside the delayed task, so the 3 s
+        // confirmation sleep inflated it and suppressed real short tasks.
         if status == .idle && oldPaneStatus == .working {
-            let workingStartedAt = sessions[index].paneWorkingStartedAt[paneId]
+            let workDuration = sessions[index].paneWorkingStartedAt[paneId].map { Date().timeIntervalSince($0) }
             Task { @MainActor in
                 try? await Task.sleep(for: .seconds(3))
                 guard let idx = self.sessions.firstIndex(where: { $0.id == sessionId }),
                       self.sessions[idx].paneStatuses[paneId] == .idle else { return }
-                if let started = workingStartedAt, Date().timeIntervalSince(started) < 10 {
-                    return
-                }
+                if let d = workDuration, d < Self.minTaskWorkDuration { return }
                 self.updateTerminalStatus(paneId, status: .taskCompleted)
             }
         }

Notchy/SessionTabBar.swift

@@ -200,7 +200,10 @@ struct SessionTab: View {
     }
 
     private func showHistory() {
-        let panel = HistoryViewerPanel(sessionName: session.projectName, sessionId: session.id)
+        // History is logged per pane (terminal.sessionId is a pane id), so read
+        // every pane in this session's split tree, not the session id — that
+        // file never exists and the viewer always showed "No history".
+        let panel = HistoryViewerPanel(sessionName: session.projectName, paneIds: session.splitRoot.allPaneIds)
         panel.makeKeyAndOrderFront(nil)
     }
 
@@ -392,7 +395,11 @@ struct SessionTab: View {
                 if let checkpoint = latestCheckpoint {
                     guard let dir = session.projectPath else { return }
                     let projectDir = (dir as NSString).deletingLastPathComponent
-                    try? CheckpointManager.shared.restoreCheckpoint(checkpoint, to: projectDir)
+                    do {
+                        try CheckpointManager.shared.restoreCheckpoint(checkpoint, to: projectDir)
+                    } catch {
+                        NSLog("Notchly: checkpoint restore failed: \(error.localizedDescription)")
+                    }
                 }
             }
             Button(L10n.shared.cancel, role: .cancel) {}
@@ -413,16 +420,4 @@ struct SessionTab: View {
     }
 }
 
-struct TabSpinnerView: View {
-    @State private var isAnimating = false
-
-    var body: some View {
-        Circle()
-            .trim(from: 0.05, to: 0.8)
-            .stroke(Color(nsColor: SessionStore.shared.currentTheme.chromeForeground), style: StrokeStyle(lineWidth: 1.5, lineCap: .round))
-            .rotationEffect(.degrees(isAnimating ? 360 : 0))
-            .animation(.linear(duration: 0.8).repeatForever(autoreverses: false), value: isAnimating)
-            .onAppear { isAnimating = true }
-    }
-}